diff mbox

[1/1] Fix LC_MONETARY for ta_LK

Message ID 1501064540-16588-1-git-send-email-akhilesh.k@samsung.com
State New
Headers show

Commit Message

Akhilesh Kumar July 26, 2017, 10:22 a.m. UTC
[BZ #21839]
        * locales/ta_LK (LC_MONETARY, LC_NUMERIC..): Fix 

Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 localedata/locales/ta_LK |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Comments

Mike FABIAN July 26, 2017, 10:49 a.m. UTC | #1
Akhilesh Kumar <akhilesh.k@samsung.com> さんはかきました:

> [BZ #21839]
>         * locales/ta_LK (LC_MONETARY, LC_NUMERIC..): Fix 
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
>  localedata/locales/ta_LK |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/localedata/locales/ta_LK b/localedata/locales/ta_LK
> index 94cd58f..e585ca4 100644
> --- a/localedata/locales/ta_LK
> +++ b/localedata/locales/ta_LK
> @@ -46,11 +46,11 @@ category "i18n:2012";LC_MEASUREMENT
>  END LC_IDENTIFICATION
>  
>  LC_COLLATE
> -copy "ta_IN"
> +copy "si_LK"
>  END LC_COLLATE

That is wrong because collation depends  on the language, not the
country. It does not make a difference in this case because both
ta_IN and si_LK just use “copy "iso14651_t1"”. But I nevertheless
consider this wrong.

>  LC_CTYPE
> -copy "ta_IN"
> +copy "si_LK"
>  END LC_CTYPE

This is certainly wrong because the LC_CTYPE part in ta_IN actually
does more than the standard "copy" and "include".

LC_CTYPE information also depends on the language, so you should
not copy this from a different language.

>  LC_MESSAGES
> @@ -58,11 +58,11 @@ copy "ta_IN"
>  END LC_MESSAGES
>  
>  LC_MONETARY
> -copy "ta_IN"
> +copy "si_LK"
>  END LC_MONETARY

This is correct because Tamil speaking people living in Sri Lanka
will use the money from Sri Lanka.

>  LC_NUMERIC
> -copy "ta_IN"
> +copy "si_LK"
>  END LC_NUMERIC

Doesn’t the number formatting also depend on the language and not so
much on the country?

>  LC_TIME
Akhilesh Kumar July 27, 2017, 7:53 a.m. UTC | #2
> >  END LC_COLLATE
>  
> That is wrong because collation depends  on the language, not the
> country. It does not make a difference in this case because both
> ta_IN and si_LK just use “copy "iso14651_t1"”. But I nevertheless

> consider this wrong.


Agree Not required 

> >  LC_CTYPE

>> -copy "ta_IN"

> > +copy "si_LK"

> >  END LC_CTYPE

>  

> This is certainly wrong because the LC_CTYPE part in ta_IN actually

> does more than the standard "copy" and "include".

>  

> LC_CTYPE information also depends on the language, so you should

> not copy this from a different language.


Agree 
  
> >  LC_MESSAGES

> > @@ -58,11 +58,11 @@ copy "ta_IN"

>  END LC_MESSAGES

>  

>  LC_MONETARY

> -copy "ta_IN"

> +copy "si_LK"

>  END LC_MONETARY

>  

> This is correct because Tamil speaking people living in Sri Lanka

> will use the money from Sri Lanka.


Please find Fix patch for ta_LK only LC_MONETARY Fix is taken 
https://sourceware.org/ml/libc-alpha/2017-07/msg00914.html 

> >  LC_NUMERIC

> > -copy "ta_IN"

> > +copy "si_LK"

>>  END LC_NUMERIC
diff mbox

Patch

diff --git a/localedata/locales/ta_LK b/localedata/locales/ta_LK
index 94cd58f..e585ca4 100644
--- a/localedata/locales/ta_LK
+++ b/localedata/locales/ta_LK
@@ -46,11 +46,11 @@  category "i18n:2012";LC_MEASUREMENT
 END LC_IDENTIFICATION
 
 LC_COLLATE
-copy "ta_IN"
+copy "si_LK"
 END LC_COLLATE
 
 LC_CTYPE
-copy "ta_IN"
+copy "si_LK"
 END LC_CTYPE
 
 LC_MESSAGES
@@ -58,11 +58,11 @@  copy "ta_IN"
 END LC_MESSAGES
 
 LC_MONETARY
-copy "ta_IN"
+copy "si_LK"
 END LC_MONETARY
 
 LC_NUMERIC
-copy "ta_IN"
+copy "si_LK"
 END LC_NUMERIC
 
 LC_TIME