From patchwork Tue Jan 18 22:47:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Aravamudan X-Patchwork-Id: 79369 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 715B6B73D1 for ; Wed, 19 Jan 2011 09:47:39 +1100 (EST) Received: by ozlabs.org (Postfix) id C6159B7135; Wed, 19 Jan 2011 09:47:33 +1100 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e34.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 54724B711B for ; Wed, 19 Jan 2011 09:47:33 +1100 (EST) Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p0IMaQn1008446 for ; Tue, 18 Jan 2011 15:36:26 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0IMlRAF091280 for ; Tue, 18 Jan 2011 15:47:27 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0IMlPRv023499 for ; Tue, 18 Jan 2011 15:47:26 -0700 Received: from arkanoid.localdomain (sig-9-65-199-218.mts.ibm.com [9.65.199.218]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p0IMlOro023390; Tue, 18 Jan 2011 15:47:25 -0700 Received: by arkanoid.localdomain (Postfix, from userid 1000) id 7593EF2B71; Tue, 18 Jan 2011 14:47:18 -0800 (PST) Date: Tue, 18 Jan 2011 14:47:18 -0800 From: Nishanth Aravamudan To: Anton Blanchard Subject: Re: 2.6.37-git17 virtual IO boot failure Message-ID: <20110118224718.GA19039@us.ibm.com> References: <20110118123152.50f75a72@kryten> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110118123152.50f75a72@kryten> X-Operating-System: Linux 2.6.35-24-generic (x86_64) User-Agent: Mutt/1.5.20 (2009-06-14) Cc: sonnyrao@us.ibm.com, miltonm@bga.com, linuxppc-dev@ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org On 18.01.2011 [12:31:52 +1100], Anton Blanchard wrote: > Hi, > > I was testing 2.6.37-git17 on a POWER7 with virtual IO and hit this: > > Trying to unpack rootfs image as initramfs... > Freeing initrd memory: 7446k freed > vio 30000000: Warning: IOMMU dma not supported: mask > 0xffffffffffffffff, table unavailable > vio 4000: Warning: IOMMU dma not supported: mask 0xffffffffffffffff, > table unavailable > vio 4001: Warning: IOMMU dma not supported: mask 0xffffffffffffffff, > table unavailable > vio 4002: Warning: IOMMU dma not supported: mask 0xffffffffffffffff, > table unavailable > vio 4004: Warning: IOMMU dma not supported: mask 0xffffffffffffffff, > table unavailable > audit: initializing netlink socket (disabled) > > Haven't had a chance to look closer yet. After debugging a bit, this would appear to be due to the second hunk of b3c73856ae47d43d0d181f9de1c1c6c0820c4515. Milton, Sonny, any thoughts? Thanks, Nish diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c index b265405..1b695fd 100644 --- a/arch/powerpc/kernel/vio.c +++ b/arch/powerpc/kernel/vio.c @@ -1257,6 +1257,10 @@ struct vio_dev *vio_register_device_node(struct device_node *of_node) viodev->dev.parent = &vio_bus_device.dev; viodev->dev.bus = &vio_bus_type; viodev->dev.release = vio_dev_release; + /* needed to ensure proper operation of coherent allocations + * later, in case driver doesn't set it explicitly */ + dma_set_mask(&viodev->dev, DMA_BIT_MASK(64)); + dma_set_coherent_mask(&viodev->dev, DMA_BIT_MASK(64)); /* register with generic device framework */ if (device_register(&viodev->dev)) {