From patchwork Tue Jul 25 07:23:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gurucharan Shetty X-Patchwork-Id: 793556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xH5PF6qy7z9s4q for ; Wed, 26 Jul 2017 03:50:25 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E11BAA84; Tue, 25 Jul 2017 17:49:52 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 50BBD99F for ; Tue, 25 Jul 2017 17:49:49 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 013BB406 for ; Tue, 25 Jul 2017 17:49:48 +0000 (UTC) Received: by mail-pg0-f65.google.com with SMTP id y129so15066905pgy.3 for ; Tue, 25 Jul 2017 10:49:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=g0fKExXDwV+zyupyJffcQHQvn8vmx9iOkb2hLTM+CRk=; b=A5yoskF8FC6dm9pb2K9dXt+N4ZWTzKGzsn1xPCetjyhV9MuaD5Hr+s7UtQqTbaAbBZ 9GdZCEXq/E0n0dYUwwzKtapwUc5MEGacQ4jids0SKM0nnaBP4b5VPM/lkAD32DsLtJ41 9A9RHsv4UkZCo/eVDN5d38kRO15V/XXFcJyLO+UQmNzJH+aheLOqDpPLja9MRhDJ2ise YX0If7oswRovl/av/y5vWUlNElZWRZQxXQwmX2wsST3h+oOUtaoGXPTeU8D17J/Cfu5U I1I+O63ANMoMjGnA3apEg9A7BQ1wLT1eB5xe2dlH7jGPATd6gm5Tk6jkIzGBMZj90mIm BE4Q== X-Gm-Message-State: AIVw113WjvyvFH3Mrjgi80nG0/vanAAVPgzwUfKuRkbIHuuOZ90E5kjc N/P8+2gB/R719GRJ X-Received: by 10.98.43.80 with SMTP id r77mr20392356pfr.92.1501004988338; Tue, 25 Jul 2017 10:49:48 -0700 (PDT) Received: from ubuntu.eng.vmware.com ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id 16sm25243870pfq.151.2017.07.25.10.49.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Jul 2017 10:49:47 -0700 (PDT) From: Gurucharan Shetty To: dev@openvswitch.org Date: Tue, 25 Jul 2017 00:23:51 -0700 Message-Id: <1500967431-23967-2-git-send-email-guru@ovn.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1500967431-23967-1-git-send-email-guru@ovn.org> References: <1500967431-23967-1-git-send-email-guru@ovn.org> X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00, DATE_IN_PAST_06_12, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 2/2] ovs-bugtool: Run the 'dmesg' command without condition. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Currently we look for files with the name of "dmesg" in "/var/log". If it exists, we don't run the command "dmesg". This is unreliable as the file does not always contain the latest dmesg information. Since OVS kernel module emits information to dmesg, we need this information to debug bugs. So always run the "dmesg" command and collect its output. Signed-off-by: Gurucharan Shetty Reviewed-by: Greg Rose Tested-by: Greg Rose Acked-by: Ben Pfaff --- utilities/bugtool/ovs-bugtool.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in index b47d9a4..e886844 100755 --- a/utilities/bugtool/ovs-bugtool.in +++ b/utilities/bugtool/ovs-bugtool.in @@ -637,9 +637,7 @@ exclude those logs from the archive. prefix_output(CAP_OPENVSWITCH_LOGS, log, last_mod_time=log_last_mod_time) - if not os.path.exists('/var/log/dmesg') and \ - not os.path.exists('/var/log/boot'): - cmd_output(CAP_SYSTEM_LOGS, [DMESG]) + cmd_output(CAP_SYSTEM_LOGS, [DMESG]) cmd_output(CAP_SYSTEM_SERVICES, [CHKCONFIG, '--list'])