[ovs-dev,1/2] ovs-bugtool: Collect OVS logs with "--ovs" option.

Submitted by Guru Shetty on July 25, 2017, 7:23 a.m.

Details

Message ID 1500967431-23967-1-git-send-email-guru@ovn.org
State Under Review
Headers show

Commit Message

Guru Shetty July 25, 2017, 7:23 a.m.
ovs-bugtool collects a lot of data. This can be time
consuming and can end up collecting a lot of redundant data.
A option "--ovs" was added a while ago to only collect
OVS relevent data. We missed adding the OVS logs to this
filter.

Signed-off-by: Gurucharan Shetty <guru@ovn.org>
---
 utilities/bugtool/ovs-bugtool.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Rose July 26, 2017, 10:26 p.m.
On 07/25/2017 12:23 AM, Gurucharan Shetty wrote:
> ovs-bugtool collects a lot of data. This can be time
> consuming and can end up collecting a lot of redundant data.
> A option "--ovs" was added a while ago to only collect
> OVS relevent data. We missed adding the OVS logs to this
> filter.
>
> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> ---
>   utilities/bugtool/ovs-bugtool.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in
> index 5eb3440..b47d9a4 100755
> --- a/utilities/bugtool/ovs-bugtool.in
> +++ b/utilities/bugtool/ovs-bugtool.in
> @@ -659,7 +659,7 @@ exclude those logs from the archive.
>       if only_ovs_info:
>           filters.add('ovs')
>           ovs_info_caps = [CAP_NETWORK_STATUS, CAP_SYSTEM_LOGS,
> -                         CAP_NETWORK_CONFIG]
> +                         CAP_OPENVSWITCH_LOGS, CAP_NETWORK_CONFIG]
>           ovs_info_list = ['process-tree']
>           # We cannot use iteritems, since we modify 'data' as we pass through
>           for (k, v) in data.items():
>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Tested-by: Greg Rose <gvrose8192@gmail.com>
Ben Pfaff Aug. 3, 2017, 7:15 p.m.
On Tue, Jul 25, 2017 at 12:23:50AM -0700, Gurucharan Shetty wrote:
> ovs-bugtool collects a lot of data. This can be time
> consuming and can end up collecting a lot of redundant data.
> A option "--ovs" was added a while ago to only collect
> OVS relevent data. We missed adding the OVS logs to this
> filter.
> 
> Signed-off-by: Gurucharan Shetty <guru@ovn.org>

Acked-by: Ben Pfaff <blp@ovn.org>

Patch hide | download patch | download mbox

diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in
index 5eb3440..b47d9a4 100755
--- a/utilities/bugtool/ovs-bugtool.in
+++ b/utilities/bugtool/ovs-bugtool.in
@@ -659,7 +659,7 @@  exclude those logs from the archive.
     if only_ovs_info:
         filters.add('ovs')
         ovs_info_caps = [CAP_NETWORK_STATUS, CAP_SYSTEM_LOGS,
-                         CAP_NETWORK_CONFIG]
+                         CAP_OPENVSWITCH_LOGS, CAP_NETWORK_CONFIG]
         ovs_info_list = ['process-tree']
         # We cannot use iteritems, since we modify 'data' as we pass through
         for (k, v) in data.items():