| Message ID | 20170725171014.25193-3-apahim@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jul 25, 2017 at 07:10:10PM +0200, Amador Pahim wrote: > The 'returncode' Popen attribute is not guaranteed to be updated. It > actually depends on a call to either poll(), wait() or communicate(). > > On the other hand, poll() will "Check if child process has terminated. > Set and return returncode attribute." > > Let's use the poll() to check whether the process is running and also > to get the updated process exit code, if any. > > Signed-off-by: Amador Pahim <apahim@redhat.com> > --- > scripts/qemu.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/scripts/qemu.py b/scripts/qemu.py index 59ed5270f8..f37e2fe58e 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -86,12 +86,12 @@ class QEMUMachine(object): raise def is_running(self): - return self._popen and (self._popen.returncode is None) + return self._popen and (self._popen.poll() is None) def exitcode(self): if self._popen is None: return None - return self._popen.returncode + return self._popen.poll() def get_pid(self): if not self.is_running():
The 'returncode' Popen attribute is not guaranteed to be updated. It actually depends on a call to either poll(), wait() or communicate(). On the other hand, poll() will "Check if child process has terminated. Set and return returncode attribute." Let's use the poll() to check whether the process is running and also to get the updated process exit code, if any. Signed-off-by: Amador Pahim <apahim@redhat.com> --- scripts/qemu.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)