rtc: ds1307: fix regmap config

Message ID 2061233f-1187-d03c-51dc-8d7ad2faf90e@gmail.com
State Accepted
Headers show

Commit Message

Heiner Kallweit July 25, 2017, 4:44 p.m.
Current max_register setting breaks reading nvram on certain chips and
also reading the standard registers on RX8130 where register map starts
at 0x10.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Fixes: 11e5890b5342 "rtc: ds1307: convert driver to regmap"
---
This fix should make it to 4.13.
---
 drivers/rtc/rtc-ds1307.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alexandre Belloni Aug. 21, 2017, 2:17 p.m. | #1
On 25/07/2017 at 18:44:04 +0200, Heiner Kallweit wrote:
> Current max_register setting breaks reading nvram on certain chips and
> also reading the standard registers on RX8130 where register map starts
> at 0x10.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Fixes: 11e5890b5342 "rtc: ds1307: convert driver to regmap"
> ---
> This fix should make it to 4.13.
> ---
>  drivers/rtc/rtc-ds1307.c | 1 -
>  1 file changed, 1 deletion(-)
> 
Applied, thanks.

Patch

diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 4fac49e5..4b43aa62 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -1301,7 +1301,6 @@  static void ds1307_clks_register(struct ds1307 *ds1307)
 static const struct regmap_config regmap_config = {
 	.reg_bits = 8,
 	.val_bits = 8,
-	.max_register = 0x12,
 };
 
 static int ds1307_probe(struct i2c_client *client,