Patchwork [U-Boot,2/3] MX51EVK: Use SWx macros in PMIC init

login
register
mail settings
Submitter Marek Vasut
Date Jan. 18, 2011, 7:30 p.m.
Message ID <1295379040-11563-2-git-send-email-marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/79345/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Marek Vasut - Jan. 18, 2011, 7:30 p.m.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 board/freescale/mx51evk/mx51evk.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
Stefano Babic - Jan. 19, 2011, 9:12 a.m.
On 01/18/2011 08:30 PM, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  board/freescale/mx51evk/mx51evk.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
> index 2160d5a..bcf1934 100644
> --- a/board/freescale/mx51evk/mx51evk.c
> +++ b/board/freescale/mx51evk/mx51evk.c

Acked-by: Stefano babic <sbabic@denx.de>

Thanks to fix this board, too.

Best regards,
Stefano Babic
Sergei Shtylyov - Jan. 19, 2011, 10:46 a.m.
Hello.

On 18-01-2011 22:30, Marek Vasut wrote:

> Signed-off-by: Marek Vasut<marek.vasut@gmail.com>

> diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
> index 2160d5a..bcf1934 100644
> --- a/board/freescale/mx51evk/mx51evk.c
> +++ b/board/freescale/mx51evk/mx51evk.c
> @@ -198,17 +198,18 @@ static void power_init(void)
>
>   	/* Set core voltage to 1.1V */
>   	val = pmic_reg_read(REG_SW_0);
> -	val = (val&  (~0x1F)) | 0x14;
> +	val = (val&  (~SWx_VOLT_MASK)) | SWx_1_100V;
>   	pmic_reg_write(REG_SW_0, val);
>
>   	/* Setup VCC (SW2) to 1.25 */
>   	val = pmic_reg_read(REG_SW_1);
> -	val = (val&  (~0x1F)) | 0x1A;
> +	val = (val&  (~SWx_VOLT_MASK)) | SWx_1_250V;
> +
>   	pmic_reg_write(REG_SW_1, val);
>
>   	/* Setup 1V2_DIG1 (SW3) to 1.25 */
>   	val = pmic_reg_read(REG_SW_2);
> -	val = (val&  (~0x1F)) | 0x1A;
> +	val = (val&  (~SWx_VOLT_MASK)) | SWx_1_250V;

    Could drop the useless parens around ~x, while at it...

WBR, Sergei

Patch

diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
index 2160d5a..bcf1934 100644
--- a/board/freescale/mx51evk/mx51evk.c
+++ b/board/freescale/mx51evk/mx51evk.c
@@ -198,17 +198,18 @@  static void power_init(void)
 
 	/* Set core voltage to 1.1V */
 	val = pmic_reg_read(REG_SW_0);
-	val = (val & (~0x1F)) | 0x14;
+	val = (val & (~SWx_VOLT_MASK)) | SWx_1_100V;
 	pmic_reg_write(REG_SW_0, val);
 
 	/* Setup VCC (SW2) to 1.25 */
 	val = pmic_reg_read(REG_SW_1);
-	val = (val & (~0x1F)) | 0x1A;
+	val = (val & (~SWx_VOLT_MASK)) | SWx_1_250V;
+
 	pmic_reg_write(REG_SW_1, val);
 
 	/* Setup 1V2_DIG1 (SW3) to 1.25 */
 	val = pmic_reg_read(REG_SW_2);
-	val = (val & (~0x1F)) | 0x1A;
+	val = (val & (~SWx_VOLT_MASK)) | SWx_1_250V;
 	pmic_reg_write(REG_SW_2, val);
 	udelay(50);