diff mbox

[U-Boot,v6,2/3] rockchip: firefly: Set the environment variable 'usbkbd' to the stdin

Message ID 1500986867-30634-3-git-send-email-leo.wen@rock-chips.com
State Accepted
Delegated to: Philipp Tomsich
Headers show

Commit Message

Leo Wen July 25, 2017, 12:47 p.m. UTC
Add the 'usbkbd' environment variable to the 'stdin', the contents of
the keyboard input can be auto-displayed on the serial terminal,so
you don't need to manually set the environment variable 'stdin'.

Signed-off-by: Leo Wen <leo.wen@rock-chips.com>
---
 include/configs/firefly-rk3288.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philipp Tomsich July 26, 2017, 11:11 a.m. UTC | #1
> Add the 'usbkbd' environment variable to the 'stdin', the contents of
> the keyboard input can be auto-displayed on the serial terminal,so
> you don't need to manually set the environment variable 'stdin'.
> 
> Signed-off-by: Leo Wen <leo.wen@rock-chips.com>
> ---
>  include/configs/firefly-rk3288.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich July 26, 2017, 4:52 p.m. UTC | #2
> Add the 'usbkbd' environment variable to the 'stdin', the contents of
> the keyboard input can be auto-displayed on the serial terminal,so
> you don't need to manually set the environment variable 'stdin'.
> 
> Signed-off-by: Leo Wen <leo.wen@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  include/configs/firefly-rk3288.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich July 27, 2017, 11:20 a.m. UTC | #3
> Add the 'usbkbd' environment variable to the 'stdin', the contents of
> the keyboard input can be auto-displayed on the serial terminal,so
> you don't need to manually set the environment variable 'stdin'.
> 
> Signed-off-by: Leo Wen <leo.wen@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  include/configs/firefly-rk3288.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to u-boot-rockchip, thanks!
diff mbox

Patch

diff --git a/include/configs/firefly-rk3288.h b/include/configs/firefly-rk3288.h
index b4dcf23..6ef0960 100644
--- a/include/configs/firefly-rk3288.h
+++ b/include/configs/firefly-rk3288.h
@@ -8,7 +8,7 @@ 
 #define __CONFIG_H
 
 #define ROCKCHIP_DEVICE_SETTINGS \
-		"stdin=serial,cros-ec-keyb\0" \
+		"stdin=serial,usbkbd\0" \
 		"stdout=serial,vidconsole\0" \
 		"stderr=serial,vidconsole\0"