| Message ID | 20170725104933.9633-1-sathya.perla@broadcom.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Jul 25, 2017 at 3:49 AM, Sathya Perla <sathya.perla@broadcom.com> wrote: > This fixes build error when CONFIG_BNXT_SRIOV is switched off: >>> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:165:16: error: 'struct >>> bnxt' has no member named 'sriov_lock' > > Reported-by: kbuild test robot <lkp@intel.com> > Fixes: 4ab0c6a8ffd7 ("bnxt_en: add support to enable VF-representors") > Signed-off-by: Sathya Perla <sathya.perla@broadcom.com> > --- > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c > index 83478e9..86850ae 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c > @@ -16,6 +16,8 @@ > #include "bnxt.h" > #include "bnxt_vfr.h" > > +#ifdef CONFIG_BNXT_SRIOV > + > #define CFA_HANDLE_INVALID 0xffff > #define VF_IDX_INVALID 0xffff > > @@ -487,3 +489,5 @@ void bnxt_dl_unregister(struct bnxt *bp) > devlink_unregister(dl); > devlink_free(dl); > } > + > +#endif /* CONFIG_BNXT_SRIOV */ This won't work. It will cause undefined symbols if CONFIG_BNXT_SRIOV is not defined. I will fix everything up and resend all 3 patches.
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c index 83478e9..86850ae 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c @@ -16,6 +16,8 @@ #include "bnxt.h" #include "bnxt_vfr.h" +#ifdef CONFIG_BNXT_SRIOV + #define CFA_HANDLE_INVALID 0xffff #define VF_IDX_INVALID 0xffff @@ -487,3 +489,5 @@ void bnxt_dl_unregister(struct bnxt *bp) devlink_unregister(dl); devlink_free(dl); } + +#endif /* CONFIG_BNXT_SRIOV */