| Message ID | 1500975563-22415-1-git-send-email-tjaalton@ubuntu.com |
|---|---|
| State | New |
| Headers | show |
On 07/25/17 11:39, Timo Aaltonen wrote: > BugLink: https://bugs.launchpad.net/bugs/1706292 > > 5917 is a GT2 so it should be in INTEL_KBL_GT2_IDS. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101691 > Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com> > --- > include/drm/i915_pciids.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index 33466bf..7b4fde9 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -305,7 +305,6 @@ > #define INTEL_KBL_GT1_IDS(info) \ > INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \ > INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \ > - INTEL_VGA_DEVICE(0x5917, info), /* DT GT1.5 */ \ > INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \ > INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \ > INTEL_VGA_DEVICE(0x5902, info), /* DT GT1 */ \ > @@ -315,6 +314,7 @@ > > #define INTEL_KBL_GT2_IDS(info) \ > INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \ > + INTEL_VGA_DEVICE(0x5917, info), /* DT GT2 */ \ > INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \ > INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \ > INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \ > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> Any plans to send this upstream? Thanks, Kleber
On 25.07.2017 11:39, Timo Aaltonen wrote: > BugLink: https://bugs.launchpad.net/bugs/1706292 > > 5917 is a GT2 so it should be in INTEL_KBL_GT2_IDS. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101691 > Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- > include/drm/i915_pciids.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index 33466bf..7b4fde9 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -305,7 +305,6 @@ > #define INTEL_KBL_GT1_IDS(info) \ > INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \ > INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \ > - INTEL_VGA_DEVICE(0x5917, info), /* DT GT1.5 */ \ > INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \ > INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \ > INTEL_VGA_DEVICE(0x5902, info), /* DT GT1 */ \ > @@ -315,6 +314,7 @@ > > #define INTEL_KBL_GT2_IDS(info) \ > INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \ > + INTEL_VGA_DEVICE(0x5917, info), /* DT GT2 */ \ > INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \ > INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \ > INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \ >
On 07/25/17 11:39, Timo Aaltonen wrote: > BugLink: https://bugs.launchpad.net/bugs/1706292 > > 5917 is a GT2 so it should be in INTEL_KBL_GT2_IDS. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101691 > Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com> > --- > include/drm/i915_pciids.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index 33466bf..7b4fde9 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -305,7 +305,6 @@ > #define INTEL_KBL_GT1_IDS(info) \ > INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \ > INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \ > - INTEL_VGA_DEVICE(0x5917, info), /* DT GT1.5 */ \ > INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \ > INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \ > INTEL_VGA_DEVICE(0x5902, info), /* DT GT1 */ \ > @@ -315,6 +314,7 @@ > > #define INTEL_KBL_GT2_IDS(info) \ > INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \ > + INTEL_VGA_DEVICE(0x5917, info), /* DT GT2 */ \ > INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \ > INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \ > INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \ > Timo reported that this patch does not really fix the issue, so I'm NACK'ing it. Kleber
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 33466bf..7b4fde9 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -305,7 +305,6 @@ #define INTEL_KBL_GT1_IDS(info) \ INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \ INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \ - INTEL_VGA_DEVICE(0x5917, info), /* DT GT1.5 */ \ INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \ INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \ INTEL_VGA_DEVICE(0x5902, info), /* DT GT1 */ \ @@ -315,6 +314,7 @@ #define INTEL_KBL_GT2_IDS(info) \ INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \ + INTEL_VGA_DEVICE(0x5917, info), /* DT GT2 */ \ INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \ INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \ INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \
BugLink: https://bugs.launchpad.net/bugs/1706292 5917 is a GT2 so it should be in INTEL_KBL_GT2_IDS. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101691 Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com> --- include/drm/i915_pciids.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)