Patchwork pxa2xx_lcd: restore updating of display

login
register
mail settings
Submitter Dmitry Eremin-Solenikov
Date Jan. 18, 2011, 4:11 p.m.
Message ID <1295367093-6011-1-git-send-email-dbaryshkov@gmail.com>
Download mbox | patch
Permalink /patch/79326/
State New
Headers show

Comments

Dmitry Eremin-Solenikov - Jan. 18, 2011, 4:11 p.m.
Recently PXA2xx lcd have stopped to be updated incrementally (picture
frozen). This patch fixes that by passing non min/max x/y, but rather
(correctly) x/y and w/h.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 hw/pxa2xx_lcd.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Aurelien Jarno - Jan. 20, 2011, 11:46 a.m.
On Tue, Jan 18, 2011 at 07:11:33PM +0300, Dmitry Eremin-Solenikov wrote:
> Recently PXA2xx lcd have stopped to be updated incrementally (picture
> frozen). This patch fixes that by passing non min/max x/y, but rather
> (correctly) x/y and w/h.
> 
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  hw/pxa2xx_lcd.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c
> index 1f2211a..5b2b07e 100644
> --- a/hw/pxa2xx_lcd.c
> +++ b/hw/pxa2xx_lcd.c
> @@ -796,9 +796,9 @@ static void pxa2xx_update_display(void *opaque)
>  
>      if (miny >= 0) {
>          if (s->orientation)
> -            dpy_update(s->ds, miny, 0, maxy, s->xres);
> +            dpy_update(s->ds, miny, 0, maxy - miny, s->xres);
>          else
> -            dpy_update(s->ds, 0, miny, s->xres, maxy);
> +            dpy_update(s->ds, 0, miny, s->xres, maxy - miny);
>      }
>      pxa2xx_lcdc_int_update(s);
>  
> -- 
> 1.7.2.3
> 

Thanks, applied.

Patch

diff --git a/hw/pxa2xx_lcd.c b/hw/pxa2xx_lcd.c
index 1f2211a..5b2b07e 100644
--- a/hw/pxa2xx_lcd.c
+++ b/hw/pxa2xx_lcd.c
@@ -796,9 +796,9 @@  static void pxa2xx_update_display(void *opaque)
 
     if (miny >= 0) {
         if (s->orientation)
-            dpy_update(s->ds, miny, 0, maxy, s->xres);
+            dpy_update(s->ds, miny, 0, maxy - miny, s->xres);
         else
-            dpy_update(s->ds, 0, miny, s->xres, maxy);
+            dpy_update(s->ds, 0, miny, s->xres, maxy - miny);
     }
     pxa2xx_lcdc_int_update(s);