| Message ID | 20110118142247.001984763@eitzenberger.org |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Holger, First of all, thanks for the patches and reports. On Tue, 18 Jan 2011, holger@eitzenberger.org wrote: > When passing something like > > create foo6 hash:ip hashsize 64 family inet6 > add foo6 20a1:1234:5678::/64 > add foo6 20a1:1234:5679::/64 > > you get: > > ipset v5.2: Error in line 1: Syntax error: plain IP address must be supplied: 20a1:1234:5678::/64 > > Should be line 2 though. Yes, good catch! Unfortunately your patch overwrites the correct line number when reported by the kernel. The proper fix was to add the missing session line number setting *before* the parser is called. Best regards, Jozsef - E-mail : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: ipset/lib/session.c =================================================================== --- ipset.orig/lib/session.c 2011-01-05 18:59:59.000000000 +0100 +++ ipset/lib/session.c 2011-01-07 13:11:33.000000000 +0100 @@ -194,7 +194,7 @@ if (session->lineno != 0 && type == IPSET_ERROR) { sprintf(session->report, "Error in line %u: ", - session->lineno); + session->lineno + 1); } offset = strlen(session->report);
When passing something like create foo6 hash:ip hashsize 64 family inet6 add foo6 20a1:1234:5678::/64 add foo6 20a1:1234:5679::/64 you get: ipset v5.2: Error in line 1: Syntax error: plain IP address must be supplied: 20a1:1234:5678::/64 Should be line 2 though. Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org>