diff mbox

[4/7] gpio: acpi: Fixup kerneldoc

Message ID 20170724145728.7662-4-thierry.reding@gmail.com
State New
Headers show

Commit Message

Thierry Reding July 24, 2017, 2:57 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

Fix up a parameter description to match the code and fix markup for a
constant to prettify output.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpio/gpiolib-acpi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andy Shevchenko July 24, 2017, 3:13 p.m. UTC | #1
On Mon, 2017-07-24 at 16:57 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Fix up a parameter description to match the code and fix markup for a
> constant to prettify output.
> 

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/gpio/gpiolib-acpi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index c9b42dd12dfa..4d2113530735 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -61,7 +61,7 @@ static int acpi_gpiochip_find(struct gpio_chip *gc,
> void *data)
>  #ifdef CONFIG_PINCTRL
>  /**
>   * acpi_gpiochip_pin_to_gpio_offset() - translates ACPI GPIO to Linux
> GPIO
> - * @chip: GPIO chip
> + * @gdev: GPIO device
>   * @pin: ACPI GPIO pin number from GpioIo/GpioInt resource
>   *
>   * Function takes ACPI GpioIo/GpioInt pin number as a parameter and
> @@ -763,7 +763,7 @@ struct gpio_desc *acpi_node_get_gpiod(struct
> fwnode_handle *fwnode,
>   * The function is idempotent, though each time it runs it will
> configure GPIO
>   * pin direction according to the flags in GpioInt resource.
>   *
> - * Return: Linux IRQ number (>%0) on success, negative errno on
> failure.
> + * Return: Linux IRQ number (> %0) on success, negative errno on
> failure.
>   */
>  int acpi_dev_gpio_irq_get(struct acpi_device *adev, int index)
>  {
Mika Westerberg July 25, 2017, 8:50 a.m. UTC | #2
On Mon, Jul 24, 2017 at 06:13:47PM +0300, Andy Shevchenko wrote:
> On Mon, 2017-07-24 at 16:57 +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > Fix up a parameter description to match the code and fix markup for a
> > constant to prettify output.
> > 
> 
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Also

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

:)
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Aug. 2, 2017, 12:09 p.m. UTC | #3
On Mon, Jul 24, 2017 at 4:57 PM, Thierry Reding
<thierry.reding@gmail.com> wrote:

> From: Thierry Reding <treding@nvidia.com>
>
> Fix up a parameter description to match the code and fix markup for a
> constant to prettify output.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Patch applied with the ACKs.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index c9b42dd12dfa..4d2113530735 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -61,7 +61,7 @@  static int acpi_gpiochip_find(struct gpio_chip *gc, void *data)
 #ifdef CONFIG_PINCTRL
 /**
  * acpi_gpiochip_pin_to_gpio_offset() - translates ACPI GPIO to Linux GPIO
- * @chip: GPIO chip
+ * @gdev: GPIO device
  * @pin: ACPI GPIO pin number from GpioIo/GpioInt resource
  *
  * Function takes ACPI GpioIo/GpioInt pin number as a parameter and
@@ -763,7 +763,7 @@  struct gpio_desc *acpi_node_get_gpiod(struct fwnode_handle *fwnode,
  * The function is idempotent, though each time it runs it will configure GPIO
  * pin direction according to the flags in GpioInt resource.
  *
- * Return: Linux IRQ number (>%0) on success, negative errno on failure.
+ * Return: Linux IRQ number (> %0) on success, negative errno on failure.
  */
 int acpi_dev_gpio_irq_get(struct acpi_device *adev, int index)
 {