| Message ID | 20170724134848.19330-5-antoine.tenart@free-electrons.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Jul 24, 2017 at 03:48:34PM +0200, Antoine Tenart wrote: > This moves the mii configuration in the ndo_open path, to allow handling > different mii configurations later and to switch between these > configurations at runtime. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > --- > drivers/net/ethernet/marvell/mvpp2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c > index 6ffff929b22a..9d204ffb9b89 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++ b/drivers/net/ethernet/marvell/mvpp2.c > @@ -5862,6 +5862,7 @@ static void mvpp2_start_dev(struct mvpp2_port *port) > /* Enable interrupts on all CPUs */ > mvpp2_interrupts_enable(port); > > + mvpp2_port_mii_set(port); Hi Antoine You probably should take a look at mvpp2_port_mii_set() and have it handle all PHY_INTERFACE_MODE_RGMII variants. Andrew
Hi Andrew, On Wed, Jul 26, 2017 at 06:11:11PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:34PM +0200, Antoine Tenart wrote: > > This moves the mii configuration in the ndo_open path, to allow handling > > different mii configurations later and to switch between these > > configurations at runtime. > > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > > --- > > drivers/net/ethernet/marvell/mvpp2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c > > index 6ffff929b22a..9d204ffb9b89 100644 > > --- a/drivers/net/ethernet/marvell/mvpp2.c > > +++ b/drivers/net/ethernet/marvell/mvpp2.c > > @@ -5862,6 +5862,7 @@ static void mvpp2_start_dev(struct mvpp2_port *port) > > /* Enable interrupts on all CPUs */ > > mvpp2_interrupts_enable(port); > > > > + mvpp2_port_mii_set(port); > > You probably should take a look at mvpp2_port_mii_set() and have it > handle all PHY_INTERFACE_MODE_RGMII variants. I'll have a look at these variants (and update the whole series). Thanks! Antoine
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 6ffff929b22a..9d204ffb9b89 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -5862,6 +5862,7 @@ static void mvpp2_start_dev(struct mvpp2_port *port) /* Enable interrupts on all CPUs */ mvpp2_interrupts_enable(port); + mvpp2_port_mii_set(port); mvpp2_port_enable(port); phy_start(ndev->phydev); netif_tx_start_all_queues(port->dev); @@ -6626,7 +6627,6 @@ static int mvpp2_port_probe(struct platform_device *pdev, goto err_free_stats; } - mvpp2_port_mii_set(port); mvpp2_port_periodic_xon_disable(port); if (priv->hw_version == MVPP21)
This moves the mii configuration in the ndo_open path, to allow handling different mii configurations later and to switch between these configurations at runtime. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)