| Message ID | 1500889471-13291-6-git-send-email-patrice.chotard@st.com |
|---|---|
| State | Rejected |
| Headers | show |
Hi, On 24 July 2017 at 03:44, <patrice.chotard@st.com> wrote: > From: Patrice Chotard <patrice.chotard@st.com> > > To avoid compilation breakage on platform that doesn't > support DM PHY but uses xhci-dwc3 driver, add PHY stub > functions. > > Cc: Ran Wang <ran.wang_1@nxp.com> > Cc: Bin Meng <bmeng.cn@gmail.com> > > Signed-off-by: Patrice Chotard <patrice.chotard@st.com> > --- > > v8: _ add genric PHY stub functions to avoid compilation issue > for platforms which uses xhci-dwc3 driver and doesn't support > generic PHY framework > > > include/generic-phy.h | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > It seems to me that these functions are not telling the truth by returning 0. Should they not return -ENOSYS? Also I saw some patches fora nop phy. Is that related? Regards, Simon
diff --git a/include/generic-phy.h b/include/generic-phy.h index 58cd2b2..eac5adc 100644 --- a/include/generic-phy.h +++ b/include/generic-phy.h @@ -122,6 +122,7 @@ struct phy_ops { int (*power_off)(struct phy *phy); }; +#ifdef CONFIG_PHY /** * generic_phy_init() - initialize the PHY port @@ -220,6 +221,47 @@ int generic_phy_get_by_index(struct udevice *user, int index, int generic_phy_get_by_name(struct udevice *user, const char *phy_name, struct phy *phy); +#else /* CONFIG_PHY */ + +static inline int generic_phy_init(struct phy *phy) +{ + return 0; +} + +static inline int generic_phy_exit(struct phy *phy) +{ + return 0; +} + +static inline int generic_phy_reset(struct phy *phy) +{ + return 0; +} + +static inline int generic_phy_power_on(struct phy *phy) +{ + return 0; +} + +static inline int generic_phy_power_off(struct phy *phy) +{ + return 0; +} + +static inline int generic_phy_get_by_index(struct udevice *user, int index, + struct phy *phy) +{ + return 0; +} + +static inline int generic_phy_get_by_name(struct udevice *user, const char *phy_name, + struct phy *phy) +{ + return 0; +} + +#endif /* CONFIG_PHY */ + /** * generic_phy_valid() - check if PHY port is valid *