diff mbox

[U-Boot,v2,17/34] env: common: Drop env_get_char_init()

Message ID 20170724032009.43994-18-sjg@chromium.org
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass July 24, 2017, 3:19 a.m. UTC 
This function does nothing but call env_get_char_spec(). Drop it and
adjust its only caller.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2: None

 env/common.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Tom Rini July 26, 2017, 4:14 p.m. UTC | #1 
On Sun, Jul 23, 2017 at 09:19:52PM -0600, Simon Glass wrote:

> This function does nothing but call env_get_char_spec(). Drop it and
> adjust its only caller.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Tom Rini <trini@konsulko.com>
diff mbox

Patch

diff --git a/env/common.c b/env/common.c
index 10c4e134f4..e919269c7f 100644
--- a/env/common.c
+++ b/env/common.c
@@ -32,11 +32,6 @@  __weak uchar env_get_char_spec(int index)
 	return *((uchar *)(gd->env_addr + index));
 }
 
-static uchar env_get_char_init(int index)
-{
-	return env_get_char_spec(index);
-}
-
 static uchar env_get_char_memory(int index)
 {
 	return *(uchar *)(gd->env_addr + index);
@@ -50,7 +45,7 @@  uchar env_get_char(int index)
 	else if (gd->flags & GD_FLG_RELOC)  /* if relocated to RAM */
 		return env_get_char_memory(index);
 	else
-		return env_get_char_init(index);
+		return env_get_char_spec(index);
 }
 
 /*