diff mbox

[v2,1/3] testing/infra/builder: dump defconfig to log

Message ID 20170723214418.7130-1-ricardo.martincoski@gmail.com
State Accepted
Headers show

Commit Message

Ricardo Martincoski July 23, 2017, 9:44 p.m. UTC
The defconfig is composed on-the-fly by test infra + tests.

Dump it to the logfile before running 'make olddefconfig' so it can
easily analysed when debugging.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
Changes v1 -> v2:
  - it's really a defconfig, not a config (Yann E. MORIN);
  - make clear on the logfile where the defconfig ends (Yann E. MORIN);
  - remove tested-by tag since I changed the patch;
  - patch renumbered since I kept the old patch 1 (developers file only)
    in the patchwork as-is;
---
 support/testing/infra/builder.py | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni July 24, 2017, 3:55 p.m. UTC | #1
Hello,

On Sun, 23 Jul 2017 18:44:16 -0300, Ricardo Martincoski wrote:
> The defconfig is composed on-the-fly by test infra + tests.
> 
> Dump it to the logfile before running 'make olddefconfig' so it can
> easily analysed when debugging.
> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> Changes v1 -> v2:
>   - it's really a defconfig, not a config (Yann E. MORIN);
>   - make clear on the logfile where the defconfig ends (Yann E. MORIN);
>   - remove tested-by tag since I changed the patch;
>   - patch renumbered since I kept the old patch 1 (developers file only)
>     in the patchwork as-is;
> ---
>  support/testing/infra/builder.py | 4 ++++
>  1 file changed, 4 insertions(+)

Series applied. Thanks!

Thomas
diff mbox

Patch

diff --git a/support/testing/infra/builder.py b/support/testing/infra/builder.py
index a475bb0a30..905b127c91 100644
--- a/support/testing/infra/builder.py
+++ b/support/testing/infra/builder.py
@@ -17,6 +17,10 @@  class Builder(object):
         config_file = os.path.join(self.builddir, ".config")
         with open(config_file, "w+") as cf:
             cf.write(self.config)
+        # dump the defconfig to the logfile for easy debugging
+        self.logfile.write("> start defconfig\n" + self.config +
+                           "> end defconfig\n")
+        self.logfile.flush()
 
         cmd = ["make",
                "O={}".format(self.builddir),