diff mbox

[1/1] s6-networking: enable SSL if libressl is selected

Message ID 20170723081602.10562-1-eric.le.bihan.dev@free.fr
State Accepted
Headers show

Commit Message

Eric Le Bihan July 23, 2017, 8:16 a.m. UTC
If LibreSSL is selected, enable the associated backend to build the
s6-tls* tools.

Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
---
 package/s6-networking/s6-networking.mk | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Arnout Vandecappelle July 23, 2017, 1 p.m. UTC | #1
On 23-07-17 10:16, Eric Le Bihan wrote:
> If LibreSSL is selected, enable the associated backend to build the
> s6-tls* tools.
> 
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> ---
>  package/s6-networking/s6-networking.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/s6-networking/s6-networking.mk b/package/s6-networking/s6-networking.mk
> index ffaf8bc..6463f5d 100644
> --- a/package/s6-networking/s6-networking.mk
> +++ b/package/s6-networking/s6-networking.mk
> @@ -23,6 +23,11 @@ S6_NETWORKING_CONF_OPTS = \
>  	$(if $(BR2_STATIC_LIBS),,--disable-allstatic) \
>  	$(SHARED_STATIC_LIBS_OPTS)
>  
> +ifeq ($(BR2_PACKAGE_LIBRESSL),y)
> +S6_NETWORKING_CONF_OPTS += --enable-ssl=libressl

 Does it also support openssl?

 Is there a corresponding --disable-ssl option?

 Regards,
 Arnout

> +S6_NETWORKING_DEPENDENCIES = libressl
> +endif
> +
>  define S6_NETWORKING_CONFIGURE_CMDS
>  	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(S6_NETWORKING_CONF_OPTS))
>  endef
>
Eric Le Bihan July 23, 2017, 2:33 p.m. UTC | #2
Hi!

On 17-07-23 15:00:34, Arnout Vandecappelle wrote:
>
>
> On 23-07-17 10:16, Eric Le Bihan wrote:
> > If LibreSSL is selected, enable the associated backend to build the
> > s6-tls* tools.
> >
> > Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> > ---
> >  package/s6-networking/s6-networking.mk | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/package/s6-networking/s6-networking.mk b/package/s6-networking/s6-networking.mk
> > index ffaf8bc..6463f5d 100644
> > --- a/package/s6-networking/s6-networking.mk
> > +++ b/package/s6-networking/s6-networking.mk
> > @@ -23,6 +23,11 @@ S6_NETWORKING_CONF_OPTS = \
> >  	$(if $(BR2_STATIC_LIBS),,--disable-allstatic) \
> >  	$(SHARED_STATIC_LIBS_OPTS)
> >
> > +ifeq ($(BR2_PACKAGE_LIBRESSL),y)
> > +S6_NETWORKING_CONF_OPTS += --enable-ssl=libressl
>
>  Does it also support openssl?

No. It only supports LibreSSL and BearSSL [1], as stated in the
documentation [2].

>  Is there a corresponding --disable-ssl option?

No. The custom build system used in skarnet softwares follows roughly
the autotools conventions, but for a "--enable-foo" option, there is no
matching "--disable-foo".

> > +S6_NETWORKING_DEPENDENCIES = libressl
> > +endif
> > +
> >  define S6_NETWORKING_CONFIGURE_CMDS
> >  	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(S6_NETWORKING_CONF_OPTS))
> >  endef

[1] https://bearssl.org/
[2] http://skarnet.org/software/s6-networking/

Regards,

--
ELB
Thomas Petazzoni July 24, 2017, 4:34 p.m. UTC | #3
Hello,

On Sun, 23 Jul 2017 10:16:02 +0200, Eric Le Bihan wrote:
> If LibreSSL is selected, enable the associated backend to build the
> s6-tls* tools.
> 
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> ---
>  package/s6-networking/s6-networking.mk | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas
diff mbox

Patch

diff --git a/package/s6-networking/s6-networking.mk b/package/s6-networking/s6-networking.mk
index ffaf8bc..6463f5d 100644
--- a/package/s6-networking/s6-networking.mk
+++ b/package/s6-networking/s6-networking.mk
@@ -23,6 +23,11 @@  S6_NETWORKING_CONF_OPTS = \
 	$(if $(BR2_STATIC_LIBS),,--disable-allstatic) \
 	$(SHARED_STATIC_LIBS_OPTS)
 
+ifeq ($(BR2_PACKAGE_LIBRESSL),y)
+S6_NETWORKING_CONF_OPTS += --enable-ssl=libressl
+S6_NETWORKING_DEPENDENCIES = libressl
+endif
+
 define S6_NETWORKING_CONFIGURE_CMDS
 	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(S6_NETWORKING_CONF_OPTS))
 endef