| Message ID | 1500761743-1669-3-git-send-email-zuban32s@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 23/07/2017 1:15, Aleksandr Bezzubikov wrote: > Unmask previously masked SHPC feature in _OSC method. > > Signed-off-by: Aleksandr Bezzubikov <zuban32s@gmail.com> > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 6b7bade..0d99585 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1850,7 +1850,7 @@ static Aml *build_q35_osc_method(void) > * Always allow native PME, AER (no dependencies) > * Never allow SHPC (no SHPC controller in this system) Seems the above comment is not longer correct :) Thanks, Marcel > */ > - aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1D), a_ctrl)); > + aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1F), a_ctrl)); > > if_ctx2 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(1)))); > /* Unknown revision */ >
2017-07-23 18:59 GMT+03:00 Marcel Apfelbaum <marcel@redhat.com>: > On 23/07/2017 1:15, Aleksandr Bezzubikov wrote: > >> Unmask previously masked SHPC feature in _OSC method. >> >> Signed-off-by: Aleksandr Bezzubikov <zuban32s@gmail.com> >> --- >> hw/i386/acpi-build.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c >> index 6b7bade..0d99585 100644 >> --- a/hw/i386/acpi-build.c >> +++ b/hw/i386/acpi-build.c >> @@ -1850,7 +1850,7 @@ static Aml *build_q35_osc_method(void) >> * Always allow native PME, AER (no dependencies) >> * Never allow SHPC (no SHPC controller in this system) >> > > Seems the above comment is not longer correct :) > Just missed it, will fix in v3. > > Thanks, > Marcel > > > */ >> - aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1D), a_ctrl)); >> + aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1F), a_ctrl)); >> if_ctx2 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(1)))); >> /* Unknown revision */ >> >> >
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6b7bade..0d99585 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1850,7 +1850,7 @@ static Aml *build_q35_osc_method(void) * Always allow native PME, AER (no dependencies) * Never allow SHPC (no SHPC controller in this system) */ - aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1D), a_ctrl)); + aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1F), a_ctrl)); if_ctx2 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(1)))); /* Unknown revision */
Unmask previously masked SHPC feature in _OSC method. Signed-off-by: Aleksandr Bezzubikov <zuban32s@gmail.com> --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)