[1/3] sparc64: recognize and support sparc M8 cpu type

Sam/David,
>
> It is way better than the hardcoded values.
> If the vales have any sort of name in the sparc specs
> the values shall be prefixed with this.
> Otherwise something like
> CPU_ID_xxx
>
> And maybe add an intro comment like this:
> /* following CPU_ID_xxx constants are used to identify the
>   * CPU type in the setup phase (see xxx.S)
> */
>

Here's a quick diff. Let me know if this looks good to you guys. I'll 
send out the patch. I have tested this on a T4.

         be,pt   %xcc, 5f
          mov    SUN4V_CHIP_NIAGARA4, %g4
-       cmp     %g2, '5'
+       cmp     %g2, CPU_ID_NIAGARA5
         be,pt   %xcc, 5f
          mov    SUN4V_CHIP_NIAGARA5, %g4
-       cmp     %g2, '6'
+       cmp     %g2, CPU_ID_M6
         be,pt   %xcc, 5f
          mov    SUN4V_CHIP_SPARC_M6, %g4
-       cmp     %g2, '7'
+       cmp     %g2, CPU_ID_M7
         be,pt   %xcc, 5f
          mov    SUN4V_CHIP_SPARC_M7, %g4
-       cmp     %g2, '8'
+       cmp     %g2, CPU_ID_M8
         be,pt   %xcc, 5f
          mov    SUN4V_CHIP_SPARC_M8, %g4
-	cmp %g2, 'N'
+       cmp     %g2, CPU_ID_SONOMA1
         be,pt   %xcc, 5f
          mov    SUN4V_CHIP_SPARC_SN, %g4
         ba,pt   %xcc, 49f
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Sat, Jul 22, 2017 at 02:26:25PM +0530, Allen wrote:
> Sam/David,
> >
> >It is way better than the hardcoded values.
> >If the vales have any sort of name in the sparc specs
> >the values shall be prefixed with this.
> >Otherwise something like
> >CPU_ID_xxx
> >
> >And maybe add an intro comment like this:
> >/* following CPU_ID_xxx constants are used to identify the
> >  * CPU type in the setup phase (see xxx.S)
> >*/
> >
> 
> Here's a quick diff. Let me know if this looks good to you guys.
> I'll send out the patch. I have tested this on a T4.
Acked-by: Sam Ravnborg <sam@ravnborg.org>

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From: Allen <allen.pais@oracle.com>
Date: Sat, 22 Jul 2017 14:26:25 +0530

> Sam/David,
>>
>> It is way better than the hardcoded values.
>> If the vales have any sort of name in the sparc specs
>> the values shall be prefixed with this.
>> Otherwise something like
>> CPU_ID_xxx
>>
>> And maybe add an intro comment like this:
>> /* following CPU_ID_xxx constants are used to identify the
>>   * CPU type in the setup phase (see xxx.S)
>> */
>>
> 
> Here's a quick diff. Let me know if this looks good to you guys. I'll
> send out the patch. I have tested this on a T4.

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html