arm: configs: aspeed_g5_defconfig: Enable Automount

Message ID 1500567765-4990-1-git-send-email-anoo@linux.vnet.ibm.com
State Rejected, archived
Headers show

Commit Message

Adriana Kobylak July 20, 2017, 4:22 p.m.
Enable CONFIG_AUTOFS4_FS to be able to support systemd
automount units.
This config is already present in the aspeed_g4_defconfig.

Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
---
 arch/arm/configs/aspeed_g5_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Joel Stanley July 26, 2017, 6:22 a.m. | #1
On Fri, Jul 21, 2017 at 1:52 AM, Adriana Kobylak
<anoo@linux.vnet.ibm.com> wrote:
> Enable CONFIG_AUTOFS4_FS to be able to support systemd
> automount units.
> This config is already present in the aspeed_g4_defconfig.

The kconfig help for this option says:

 If you are not a part of a fairly large, distributed network or
 don't have a laptop which needs to dynamically reconfigure to the
 local network, you probably do not need an automounter, and can say
 N here.

I'm not overly familiar with systemd automount units. Can you explain
why we need this option enabled?

Cheers,

Joel


>
> Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
> ---
>  arch/arm/configs/aspeed_g5_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
> index 1868442..c8bd79e 100644
> --- a/arch/arm/configs/aspeed_g5_defconfig
> +++ b/arch/arm/configs/aspeed_g5_defconfig
> @@ -193,6 +193,7 @@ CONFIG_FSI_SBEFIFO=y
>  CONFIG_OCCFIFO=y
>  CONFIG_FIRMWARE_MEMMAP=y
>  CONFIG_FANOTIFY=y
> +CONFIG_AUTOFS4_FS=y
>  CONFIG_OVERLAY_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_JFFS2_FS=y
> --
> 1.8.2.2
>
Patrick Williams July 26, 2017, 1:06 p.m. | #2
On Wed, Jul 26, 2017 at 03:52:50PM +0930, Joel Stanley wrote:
> On Fri, Jul 21, 2017 at 1:52 AM, Adriana Kobylak
> <anoo@linux.vnet.ibm.com> wrote:
> > Enable CONFIG_AUTOFS4_FS to be able to support systemd
> > automount units.
> > This config is already present in the aspeed_g4_defconfig.
> 
> The kconfig help for this option says:
> 
>  If you are not a part of a fairly large, distributed network or
>  don't have a laptop which needs to dynamically reconfigure to the
>  local network, you probably do not need an automounter, and can say
>  N here.
> 
> I'm not overly familiar with systemd automount units. Can you explain
> why we need this option enabled?

This is not needed.  I similarly turned down the changes in Yocto.  We
can accomplish the same thing with a static mount.

> 
> Cheers,
> 
> Joel
> 
> 
> >
> > Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
> > ---
> >  arch/arm/configs/aspeed_g5_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
> > index 1868442..c8bd79e 100644
> > --- a/arch/arm/configs/aspeed_g5_defconfig
> > +++ b/arch/arm/configs/aspeed_g5_defconfig
> > @@ -193,6 +193,7 @@ CONFIG_FSI_SBEFIFO=y
> >  CONFIG_OCCFIFO=y
> >  CONFIG_FIRMWARE_MEMMAP=y
> >  CONFIG_FANOTIFY=y
> > +CONFIG_AUTOFS4_FS=y
> >  CONFIG_OVERLAY_FS=y
> >  CONFIG_TMPFS=y
> >  CONFIG_JFFS2_FS=y
> > --
> > 1.8.2.2
> >

Patch

diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
index 1868442..c8bd79e 100644
--- a/arch/arm/configs/aspeed_g5_defconfig
+++ b/arch/arm/configs/aspeed_g5_defconfig
@@ -193,6 +193,7 @@  CONFIG_FSI_SBEFIFO=y
 CONFIG_OCCFIFO=y
 CONFIG_FIRMWARE_MEMMAP=y
 CONFIG_FANOTIFY=y
+CONFIG_AUTOFS4_FS=y
 CONFIG_OVERLAY_FS=y
 CONFIG_TMPFS=y
 CONFIG_JFFS2_FS=y