| Message ID | 20170720134716.13049-2-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 07/20/2017 10:47 AM, Alex Bennée wrote: > While adding the current user is a useful default behaviour for > creating new images it is not appropriate for Travis which already has > a default user. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/docker/Makefile.include | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > index aaab1a4208..d7dafdbd27 100644 > --- a/tests/docker/Makefile.include > +++ b/tests/docker/Makefile.include > @@ -71,6 +71,7 @@ docker-image-debian-ppc64el-cross: docker-image-debian9 > docker-image-debian-s390x-cross: docker-image-debian9 > docker-image-debian-win32-cross: docker-image-debian8-mxe > docker-image-debian-win64-cross: docker-image-debian8-mxe > +docker-image-travis: NOUSER=1 Cool you kept it ordered :) I'm surprised we need to install the full LaTeX stack to be able to compile the device-tree-compiler... Reading https://docs.travis-ci.com/user/environment-variables#default-environment-variables I think it'd be a better match if we also use those default environment variables, at least: DEBIAN_FRONTEND=noninteractive LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 what do you think? Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > # Expand all the pre-requistes for each docker image and test combination > $(foreach i,$(DOCKER_IMAGES), \ >
Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > On 07/20/2017 10:47 AM, Alex Bennée wrote: >> While adding the current user is a useful default behaviour for >> creating new images it is not appropriate for Travis which already has >> a default user. >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> tests/docker/Makefile.include | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include >> index aaab1a4208..d7dafdbd27 100644 >> --- a/tests/docker/Makefile.include >> +++ b/tests/docker/Makefile.include >> @@ -71,6 +71,7 @@ docker-image-debian-ppc64el-cross: docker-image-debian9 >> docker-image-debian-s390x-cross: docker-image-debian9 >> docker-image-debian-win32-cross: docker-image-debian8-mxe >> docker-image-debian-win64-cross: docker-image-debian8-mxe >> +docker-image-travis: NOUSER=1 > > Cool you kept it ordered :) > > I'm surprised we need to install the full LaTeX stack to be able to > compile the device-tree-compiler... Hmm I think installing build-deps is a little extreme as we are not re-building the device-tree-compiler but using it. > > Reading > https://docs.travis-ci.com/user/environment-variables#default-environment-variables > I think it'd be a better match if we also use those default > environment variables, at least: > > DEBIAN_FRONTEND=noninteractive > LANG=en_US.UTF-8 > LC_ALL=en_US.UTF-8 > > what do you think? Sure - it does reduce the noise somewhat. > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > >> # Expand all the pre-requistes for each docker image and test >> combination >> $(foreach i,$(DOCKER_IMAGES), \ >> -- Alex Bennée
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index aaab1a4208..d7dafdbd27 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -71,6 +71,7 @@ docker-image-debian-ppc64el-cross: docker-image-debian9 docker-image-debian-s390x-cross: docker-image-debian9 docker-image-debian-win32-cross: docker-image-debian8-mxe docker-image-debian-win64-cross: docker-image-debian8-mxe +docker-image-travis: NOUSER=1 # Expand all the pre-requistes for each docker image and test combination $(foreach i,$(DOCKER_IMAGES), \
While adding the current user is a useful default behaviour for creating new images it is not appropriate for Travis which already has a default user. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tests/docker/Makefile.include | 1 + 1 file changed, 1 insertion(+)