diff mbox

[V2] tune2fs: edit dire warning about check intervals

Message ID 3d574f21-a93c-e1ae-2b92-d4b1d1156fb4@redhat.com
State Accepted, archived
Headers show

Commit Message

Eric Sandeen July 19, 2017, 5:26 p.m. UTC
Time & mount-count based checks have been off by default for quite some
time now, but the dire warning about disabling them remains in the
tune2fs manpage, which is confusing.  We did "strongly consider
the consequences" and disabled it by default, no need to scare the
user about it now.  Inform the user of the consequences in a more
measured tone.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

V2: explain that the default of no-check is a tradeoff.
    Edit the -i section as well.

Comments

Andreas Dilger July 19, 2017, 5:29 p.m. UTC | #1
> On Jul 19, 2017, at 11:26 AM, Eric Sandeen <sandeen@redhat.com> wrote:
> 
> Time & mount-count based checks have been off by default for quite some
> time now, but the dire warning about disabling them remains in the
> tune2fs manpage, which is confusing.  We did "strongly consider
> the consequences" and disabled it by default, no need to scare the
> user about it now.  Inform the user of the consequences in a more
> measured tone.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> 
> V2: explain that the default of no-check is a tradeoff.
>    Edit the -i section as well.
> 
> 
> diff --git a/misc/tune2fs.8.in b/misc/tune2fs.8.in
> index 5c885f9..eccf277 100644
> --- a/misc/tune2fs.8.in
> +++ b/misc/tune2fs.8.in
> @@ -134,7 +134,9 @@ Staggering the mount-counts at which filesystems are forcibly
> checked will avoid all filesystems being checked at one time
> when using journaled filesystems.
> .sp
> -You should strongly consider the consequences of disabling
> +Mount-count-dependent checking is disabled by default to avoid
> +unanticipated long reboots while e2fsck does its work.  However,
> +you may wish to consider the consequences of disabling
> mount-count-dependent checking entirely.  Bad disk drives, cables,
> memory, and kernel bugs could all corrupt a filesystem without
> marking the filesystem dirty or in error.  If you are using
> @@ -289,15 +291,10 @@ as months, and
> .B w
> as weeks.  A value of zero will disable the time-dependent checking.
> .sp
> -It is strongly recommended that either
> +There are pros and cons to disabling these periodic checks; see the
> +discussion under the
> .B \-c
> -(mount-count-dependent) or
> -.B \-i
> -(time-dependent) checking be enabled to force periodic full
> -.BR e2fsck (8)
> -checking of the filesystem.  Failure to do so may lead to filesystem
> -corruption (due to bad disks, cables, memory, or kernel bugs) going
> -unnoticed, ultimately resulting in data loss or corruption.
> +(mount-count-dependent check) option for details.
> .TP
> .B \-I
> Change the inode size used by the file system.   This requires rewriting
> 
> 


Cheers, Andreas
Theodore Ts'o July 23, 2017, 10:36 p.m. UTC | #2
On Wed, Jul 19, 2017 at 12:26:19PM -0500, Eric Sandeen wrote:
> Time & mount-count based checks have been off by default for quite some
> time now, but the dire warning about disabling them remains in the
> tune2fs manpage, which is confusing.  We did "strongly consider
> the consequences" and disabled it by default, no need to scare the
> user about it now.  Inform the user of the consequences in a more
> measured tone.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>

Thanks, applied.

					- Ted
diff mbox

Patch

diff --git a/misc/tune2fs.8.in b/misc/tune2fs.8.in
index 5c885f9..eccf277 100644
--- a/misc/tune2fs.8.in
+++ b/misc/tune2fs.8.in
@@ -134,7 +134,9 @@  Staggering the mount-counts at which filesystems are forcibly
 checked will avoid all filesystems being checked at one time
 when using journaled filesystems.
 .sp
-You should strongly consider the consequences of disabling
+Mount-count-dependent checking is disabled by default to avoid
+unanticipated long reboots while e2fsck does its work.  However,
+you may wish to consider the consequences of disabling
 mount-count-dependent checking entirely.  Bad disk drives, cables,
 memory, and kernel bugs could all corrupt a filesystem without
 marking the filesystem dirty or in error.  If you are using
@@ -289,15 +291,10 @@  as months, and
 .B w
 as weeks.  A value of zero will disable the time-dependent checking.
 .sp
-It is strongly recommended that either
+There are pros and cons to disabling these periodic checks; see the
+discussion under the
 .B \-c
-(mount-count-dependent) or
-.B \-i
-(time-dependent) checking be enabled to force periodic full
-.BR e2fsck (8)
-checking of the filesystem.  Failure to do so may lead to filesystem
-corruption (due to bad disks, cables, memory, or kernel bugs) going
-unnoticed, ultimately resulting in data loss or corruption.
+(mount-count-dependent check) option for details.
 .TP
 .B \-I
 Change the inode size used by the file system.   This requires rewriting