From patchwork Sun Jan 16 18:53:40 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 79097 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C02B9B7043 for ; Mon, 17 Jan 2011 05:54:19 +1100 (EST) Received: from localhost ([127.0.0.1]:42595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PeXk0-0005vK-BV for incoming@patchwork.ozlabs.org; Sun, 16 Jan 2011 13:54:16 -0500 Received: from [140.186.70.92] (port=51448 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PeXjV-0005vF-1H for qemu-devel@nongnu.org; Sun, 16 Jan 2011 13:53:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PeXjT-0005KN-RW for qemu-devel@nongnu.org; Sun, 16 Jan 2011 13:53:44 -0500 Received: from hall.aurel32.net ([88.191.126.93]:33197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PeXjT-0005KF-Lk for qemu-devel@nongnu.org; Sun, 16 Jan 2011 13:53:43 -0500 Received: from [2001:470:d4ed:0:5e26:aff:fe2b:6f5b] (helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1PeXjR-0006vp-IO; Sun, 16 Jan 2011 19:53:41 +0100 Received: from aurel32 by volta.aurel32.net with local (Exim 4.72) (envelope-from ) id 1PeXjR-0003It-2R; Sun, 16 Jan 2011 19:53:41 +0100 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Sun, 16 Jan 2011 19:53:40 +0100 Message-Id: <1295204020-12669-1-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.2.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Aurelien Jarno Subject: [Qemu-devel] [PATCH] usb-hid: modifiers should generate an event X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When a modifier key is pressed or released, the USB HID keyboard still answers NAK, unless another key is also pressed or released. The patch fixes that by calling usb_hid_changed() when a modifier key is pressed or released. Signed-off-by: Aurelien Jarno --- hw/usb-hid.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c index e8de301..12bf46f 100644 --- a/hw/usb-hid.c +++ b/hw/usb-hid.c @@ -460,15 +460,18 @@ static void usb_keyboard_event(void *opaque, int keycode) case 0xe0: if (s->modifiers & (1 << 9)) { s->modifiers ^= 3 << 8; + usb_hid_changed(hs); return; } case 0xe1 ... 0xe7: if (keycode & (1 << 7)) { s->modifiers &= ~(1 << (hid_code & 0x0f)); + usb_hid_changed(hs); return; } case 0xe8 ... 0xef: s->modifiers |= 1 << (hid_code & 0x0f); + usb_hid_changed(hs); return; }