[v2,06/25] dt-bindings: qcom_nandc: remove chip select compatible string
diff mbox

Message ID 1500464893-11352-7-git-send-email-absahu@codeaurora.org
State Accepted
Delegated to: Boris Brezillon
Headers show

Commit Message

Abhishek Sahu July 19, 2017, 11:47 a.m. UTC
Currently the compatible “qcom,nandcs” is being used for each
connected NAND device to support for multiple NAND devices in the
same bus. The same thing can be achieved by looking reg property
for each sub nodes which contains the chip select number so this
patch removes the use of “qcom,nandcs” for specifying NAND device
sub nodes.

Since there is no user for this driver currently in so
changing compatible string is safe.

Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
---
 Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 2 --
 1 file changed, 2 deletions(-)

Comments

Rob Herring July 24, 2017, 7:14 p.m. UTC | #1
On Wed, Jul 19, 2017 at 05:17:54PM +0530, Abhishek Sahu wrote:
> Currently the compatible “qcom,nandcs” is being used for each
> connected NAND device to support for multiple NAND devices in the
> same bus. The same thing can be achieved by looking reg property
> for each sub nodes which contains the chip select number so this
> patch removes the use of “qcom,nandcs” for specifying NAND device
> sub nodes.
> 
> Since there is no user for this driver currently in so
> changing compatible string is safe.
> 
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 2 --
>  1 file changed, 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>
Boris Brezillon Aug. 4, 2017, 7:47 a.m. UTC | #2
On Wed, 19 Jul 2017 17:17:54 +0530
Abhishek Sahu <absahu@codeaurora.org> wrote:

> Currently the compatible “qcom,nandcs” is being used for each
> connected NAND device to support for multiple NAND devices in the
> same bus. The same thing can be achieved by looking reg property
> for each sub nodes which contains the chip select number so this
> patch removes the use of “qcom,nandcs” for specifying NAND device
> sub nodes.
> 
> Since there is no user for this driver currently in so
> changing compatible string is safe.
> 
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>

Applied to nand/next.

Thanks,

Boris

> ---
>  Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
> index 4511918..b24adfe 100644
> --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
> +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
> @@ -28,7 +28,6 @@ chip-selects which (may) contain NAND flash chips. Their properties are as
>  follows.
>  
>  Required properties:
> -- compatible:		should contain "qcom,nandcs"
>  - reg:			a single integer representing the chip-select
>  			number (e.g., 0, 1, 2, etc.)
>  - #address-cells:	see partition.txt
> @@ -62,7 +61,6 @@ nand@1ac00000 {
>  	#size-cells = <0>;
>  
>  	nandcs@0 {
> -		compatible = "qcom,nandcs";
>  		reg = <0>;
>  
>  		nand-ecc-strength = <4>;

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
index 4511918..b24adfe 100644
--- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
+++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
@@ -28,7 +28,6 @@  chip-selects which (may) contain NAND flash chips. Their properties are as
 follows.
 
 Required properties:
-- compatible:		should contain "qcom,nandcs"
 - reg:			a single integer representing the chip-select
 			number (e.g., 0, 1, 2, etc.)
 - #address-cells:	see partition.txt
@@ -62,7 +61,6 @@  nand@1ac00000 {
 	#size-cells = <0>;
 
 	nandcs@0 {
-		compatible = "qcom,nandcs";
 		reg = <0>;
 
 		nand-ecc-strength = <4>;