Message ID | 1500370724-28469-4-git-send-email-patrice.chotard@st.com |
---|---|
State | Accepted |
Headers | show |
On 18/07/2017 11:38, patrice.chotard@st.com wrote: > From: Patrice Chotard <patrice.chotard@st.com> > > phy->dev need to be set to NULL in case of generic_phy_get_by_index() > fails. Then phy->dev can be used to check if the phy is valid > > Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com> > Signed-off-by: Patrice Chotard <patrice.chotard@st.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > v7: _ none > v6: _ none > v5: _ none > v4: _ ensure that phy->dev is set to NULL in case of > generic_phy_get_by_index() fails > > > drivers/phy/phy-uclass.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c > index d8b8d58..68e518f 100644 > --- a/drivers/phy/phy-uclass.c > +++ b/drivers/phy/phy-uclass.c > @@ -45,6 +45,7 @@ int generic_phy_get_by_index(struct udevice *dev, int index, > debug("%s(dev=%p, index=%d, phy=%p)\n", __func__, dev, index, phy); > > assert(phy); > + phy->dev = NULL; > ret = dev_read_phandle_with_args(dev, "phys", "#phy-cells", 0, index, > &args); > if (ret) { Reviewed-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c index d8b8d58..68e518f 100644 --- a/drivers/phy/phy-uclass.c +++ b/drivers/phy/phy-uclass.c @@ -45,6 +45,7 @@ int generic_phy_get_by_index(struct udevice *dev, int index, debug("%s(dev=%p, index=%d, phy=%p)\n", __func__, dev, index, phy); assert(phy); + phy->dev = NULL; ret = dev_read_phandle_with_args(dev, "phys", "#phy-cells", 0, index, &args); if (ret) {