| Message ID | 1500352203-21513-2-git-send-email-jeffy.chen@rock-chips.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jul 18, 2017 at 12:29:59PM +0800, Jeffy Chen wrote: > The earlycon would be alive outside the init code in these cases: > 1/ we have keep_bootcon in cmdline. > 2/ we don't have a real console to switch to. > > So remove the __init marking to avoid invalid memory access. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > --- > I can't apply "RFC" patches. If you have tested and found this series to be correct, can you resend it without that on the patch? thanks, greg k-h
Hi Greg, On 07/18/2017 01:08 PM, Greg KH wrote: > On Tue, Jul 18, 2017 at 12:29:59PM +0800, Jeffy Chen wrote: >> The earlycon would be alive outside the init code in these cases: >> 1/ we have keep_bootcon in cmdline. >> 2/ we don't have a real console to switch to. >> >> So remove the __init marking to avoid invalid memory access. >> >> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> >> --- >> > > I can't apply "RFC" patches. If you have tested and found this series > to be correct, can you resend it without that on the patch? oh, sorry, i'll resend it :) but i'm still not sure how to fix other hang cases(mentioned in the cover-letter, earlycon's required clks/pm domain been disabled by ignore unused initcalls or serial console driver's runtime suspend). > > thanks, > > greg k-h > > >
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c index 5ac06fc..77fe306 100644 --- a/drivers/tty/serial/arc_uart.c +++ b/drivers/tty/serial/arc_uart.c @@ -549,8 +549,8 @@ static struct console arc_console = { .data = &arc_uart_driver }; -static __init void arc_early_serial_write(struct console *con, const char *s, - unsigned int n) +static void arc_early_serial_write(struct console *con, const char *s, + unsigned int n) { struct earlycon_device *dev = con->data;
The earlycon would be alive outside the init code in these cases: 1/ we have keep_bootcon in cmdline. 2/ we don't have a real console to switch to. So remove the __init marking to avoid invalid memory access. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- drivers/tty/serial/arc_uart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)