diff mbox

[Z/A] UBUNTU: SAUCE: (no-up) Novalink requirement for IBMVETH

Message ID 20170717200643.23011-1-gwalbon@linux.vnet.ibm.com
State New
Headers show

Commit Message

Gustavo Walbon July 17, 2017, 8:06 p.m. UTC 
BugLink: http://bugs.launchpad.net/bugs/1704479

As Novalink has required a change in config file to change the
IBMVETH to module state instead of built in.

Signed-off-by: Gustavo Walbon <gwalbon@linux.vnet.ibm.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
---
 arch/powerpc/configs/pseries_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Seth Forshee July 17, 2017, 9:40 p.m. UTC | #1 
On Mon, Jul 17, 2017 at 05:06:43PM -0300, Gustavo Walbon wrote:
> BugLink: http://bugs.launchpad.net/bugs/1704479
> 
> As Novalink has required a change in config file to change the
> IBMVETH to module state instead of built in.
> 
> Signed-off-by: Gustavo Walbon <gwalbon@linux.vnet.ibm.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  arch/powerpc/configs/pseries_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
> index 4ff68b7..3cfaf3e 100644
> --- a/arch/powerpc/configs/pseries_defconfig
> +++ b/arch/powerpc/configs/pseries_defconfig
> @@ -165,7 +165,7 @@ CONFIG_BNX2X=m
>  CONFIG_CHELSIO_T1=m
>  CONFIG_BE2NET=m
>  CONFIG_S2IO=m
> -CONFIG_IBMVETH=y
> +CONFIG_IBMVETH=m
>  CONFIG_EHEA=y
>  CONFIG_E100=y
>  CONFIG_E1000=y

This isn't going to accomplish what you want.

The configs for the Ubuntu common kernels are kept in the
debian.master/config directory, split so that values which are common to
all architectures/flavors are kept in
debian.master/config/config.common.ubuntu and others are kept in
architecture/flavor specific config files. In this case the value is in
config.common.ubuntu, so you'll want to change it there. It's advisable
to change the value in debian.master/config/annotations too. There's no
need to change pseries_defconfig.

After you change an option you should always run 'fakeroot debian/rules
updateconfigs' to regenerate the split configuration files, just in case
the changes result in a need to move an option from on file to another
(in this case they should not).

Thanks,
Seth
diff mbox

Patch

diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
index 4ff68b7..3cfaf3e 100644
--- a/arch/powerpc/configs/pseries_defconfig
+++ b/arch/powerpc/configs/pseries_defconfig
@@ -165,7 +165,7 @@  CONFIG_BNX2X=m
 CONFIG_CHELSIO_T1=m
 CONFIG_BE2NET=m
 CONFIG_S2IO=m
-CONFIG_IBMVETH=y
+CONFIG_IBMVETH=m
 CONFIG_EHEA=y
 CONFIG_E100=y
 CONFIG_E1000=y