| Message ID | 20170717140329.8199-1-sr@denx.de |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
Hi Stefan, On Mon, Jul 17, 2017 at 10:03 PM, Stefan Roese <sr@denx.de> wrote: > To support the Micron SPI NOR flashes, this patch enables the support in > defconfig. This increases the U-Boot binary too much so that it does > not fit into its area in the ROM. So also move the VIDEO BIOS blob > a bit to make some space here. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Simon Glass <sjg@chromium.org> > Cc: Bin Meng <bmeng.cn@gmail.com> > --- > configs/theadorable-x86-dfi-bt700_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig > index 1703cee841..30a40e3b16 100644 > --- a/configs/theadorable-x86-dfi-bt700_defconfig > +++ b/configs/theadorable-x86-dfi-bt700_defconfig > @@ -6,6 +6,7 @@ CONFIG_HAVE_INTEL_ME=y > CONFIG_ENABLE_MRC_CACHE=y > CONFIG_SMP=y > CONFIG_HAVE_VGA_BIOS=y > +CONFIG_VGA_BIOS_ADDR=0xfffa0000 > CONFIG_GENERATE_PIRQ_TABLE=y > CONFIG_GENERATE_MP_TABLE=y > CONFIG_GENERATE_ACPI_TABLE=y > @@ -53,6 +54,7 @@ CONFIG_MMC_SDHCI_SDMA=y > CONFIG_SPI_FLASH=y > CONFIG_SPI_FLASH_GIGADEVICE=y > CONFIG_SPI_FLASH_MACRONIX=y > +CONFIG_SPI_FLASH_SPANSION=y Commit message says Micron, but here is Spansion. This is confusing. > CONFIG_SPI_FLASH_STMICRO=y > CONFIG_SPI_FLASH_WINBOND=y > CONFIG_DM_ETH=y > -- Regards, Bin
On Tue, Jul 18, 2017 at 9:14 AM, Bin Meng <bmeng.cn@gmail.com> wrote: > Hi Stefan, > > On Mon, Jul 17, 2017 at 10:03 PM, Stefan Roese <sr@denx.de> wrote: >> To support the Micron SPI NOR flashes, this patch enables the support in >> defconfig. This increases the U-Boot binary too much so that it does >> not fit into its area in the ROM. So also move the VIDEO BIOS blob >> a bit to make some space here. >> >> Signed-off-by: Stefan Roese <sr@denx.de> >> Cc: Simon Glass <sjg@chromium.org> >> Cc: Bin Meng <bmeng.cn@gmail.com> >> --- >> configs/theadorable-x86-dfi-bt700_defconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig >> index 1703cee841..30a40e3b16 100644 >> --- a/configs/theadorable-x86-dfi-bt700_defconfig >> +++ b/configs/theadorable-x86-dfi-bt700_defconfig >> @@ -6,6 +6,7 @@ CONFIG_HAVE_INTEL_ME=y >> CONFIG_ENABLE_MRC_CACHE=y >> CONFIG_SMP=y >> CONFIG_HAVE_VGA_BIOS=y >> +CONFIG_VGA_BIOS_ADDR=0xfffa0000 >> CONFIG_GENERATE_PIRQ_TABLE=y >> CONFIG_GENERATE_MP_TABLE=y >> CONFIG_GENERATE_ACPI_TABLE=y >> @@ -53,6 +54,7 @@ CONFIG_MMC_SDHCI_SDMA=y >> CONFIG_SPI_FLASH=y >> CONFIG_SPI_FLASH_GIGADEVICE=y >> CONFIG_SPI_FLASH_MACRONIX=y >> +CONFIG_SPI_FLASH_SPANSION=y > > Commit message says Micron, but here is Spansion. This is confusing. > >> CONFIG_SPI_FLASH_STMICRO=y >> CONFIG_SPI_FLASH_WINBOND=y >> CONFIG_DM_ETH=y >> -- Other than the confusing commit message, Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig index 1703cee841..30a40e3b16 100644 --- a/configs/theadorable-x86-dfi-bt700_defconfig +++ b/configs/theadorable-x86-dfi-bt700_defconfig @@ -6,6 +6,7 @@ CONFIG_HAVE_INTEL_ME=y CONFIG_ENABLE_MRC_CACHE=y CONFIG_SMP=y CONFIG_HAVE_VGA_BIOS=y +CONFIG_VGA_BIOS_ADDR=0xfffa0000 CONFIG_GENERATE_PIRQ_TABLE=y CONFIG_GENERATE_MP_TABLE=y CONFIG_GENERATE_ACPI_TABLE=y @@ -53,6 +54,7 @@ CONFIG_MMC_SDHCI_SDMA=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_GIGADEVICE=y CONFIG_SPI_FLASH_MACRONIX=y +CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_DM_ETH=y
To support the Micron SPI NOR flashes, this patch enables the support in defconfig. This increases the U-Boot binary too much so that it does not fit into its area in the ROM. So also move the VIDEO BIOS blob a bit to make some space here. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Simon Glass <sjg@chromium.org> Cc: Bin Meng <bmeng.cn@gmail.com> --- configs/theadorable-x86-dfi-bt700_defconfig | 2 ++ 1 file changed, 2 insertions(+)