[1/2] arch/mips: improve help text of NaN option

Submitted by Vicente Olivert Riera on July 17, 2017, 12:22 p.m.

Details

Message ID 20170717122255.61795-1-Vincent.Riera@imgtec.com
State Accepted
Headers show

Commit Message

Vicente Olivert Riera July 17, 2017, 12:22 p.m.
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 arch/Config.in.mips | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni July 17, 2017, 12:56 p.m.
Hello,

On Mon, 17 Jul 2017 13:22:54 +0100, Vicente Olivert Riera wrote:

> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
> index 7dd69659d..f2b352b0b 100644
> --- a/arch/Config.in.mips
> +++ b/arch/Config.in.mips
> @@ -169,7 +169,9 @@ choice
>  	depends on BR2_mips_32r5 || BR2_mips_64r5
>  	default BR2_MIPS_ENABLE_NAN_2008
>  	help
> -	  NaN encoding to be used
> +	  MIPS supports two different NaN encodings, legacy and 2008.
> +	  Information about MIPS NaN encodings can be found here:
> +	  https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html

Is it useful (and correct?) to say that the Linux kernel, built for
MIPS32r5, by default expect the 2008 NaN encoding?

Thomas
Vicente Olivert Riera July 17, 2017, 4:57 p.m.
Hi Thomas,

On 17/07/17 13:56, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 17 Jul 2017 13:22:54 +0100, Vicente Olivert Riera wrote:
> 
>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>> index 7dd69659d..f2b352b0b 100644
>> --- a/arch/Config.in.mips
>> +++ b/arch/Config.in.mips
>> @@ -169,7 +169,9 @@ choice
>>  	depends on BR2_mips_32r5 || BR2_mips_64r5
>>  	default BR2_MIPS_ENABLE_NAN_2008
>>  	help
>> -	  NaN encoding to be used
>> +	  MIPS supports two different NaN encodings, legacy and 2008.
>> +	  Information about MIPS NaN encodings can be found here:
>> +	  https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html
> 
> Is it useful (and correct?) to say that the Linux kernel, built for
> MIPS32r5, by default expect the 2008 NaN encoding?

It is correct, but since nan2008 is the default I think is not worth
mentioning it. If you change the default value is because you know what
you are doing, right?

Vincent

> 
> Thomas
>
Thomas Petazzoni July 18, 2017, 7:53 a.m.
Hello,

On Mon, 17 Jul 2017 17:57:22 +0100, Vicente Olivert Riera wrote:

> > Is it useful (and correct?) to say that the Linux kernel, built for
> > MIPS32r5, by default expect the 2008 NaN encoding?  
> 
> It is correct, but since nan2008 is the default I think is not worth
> mentioning it. If you change the default value is because you know what
> you are doing, right?

OK, makes sense. Thanks!

Thomas
Thomas Petazzoni July 19, 2017, 7:48 p.m.
Hello,

On Mon, 17 Jul 2017 13:22:54 +0100, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  arch/Config.in.mips | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Both applied, thanks!

Have you had the chance to look at the -mnan issue with old gcc
versions ? This is currently making the autobuilders quite noisy, which
isn't nice.

Thanks!

Thomas

Patch hide | download patch | download mbox

diff --git a/arch/Config.in.mips b/arch/Config.in.mips
index 7dd69659d..f2b352b0b 100644
--- a/arch/Config.in.mips
+++ b/arch/Config.in.mips
@@ -169,7 +169,9 @@  choice
 	depends on BR2_mips_32r5 || BR2_mips_64r5
 	default BR2_MIPS_ENABLE_NAN_2008
 	help
-	  NaN encoding to be used
+	  MIPS supports two different NaN encodings, legacy and 2008.
+	  Information about MIPS NaN encodings can be found here:
+	  https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html
 
 config BR2_MIPS_ENABLE_NAN_LEGACY
 	bool "legacy"