[next] net: bcmgenet: return NULL rather than 0 for null pointer

Submitted by Colin King on July 17, 2017, 9:07 a.m.

Details

Message ID 20170717090725.32540-1-colin.king@canonical.com
State Changes Requested
Delegated to: David Miller
Headers show

Commit Message

Colin King July 17, 2017, 9:07 a.m.
From: Colin Ian King <colin.king@canonical.com>

Don't return plain integer 0, instead return NULL

Fixes sparse warning:
warning: Using plain integer as NULL pointer

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller July 17, 2017, 3:55 p.m.
From: Colin King <colin.king@canonical.com>
Date: Mon, 17 Jul 2017 10:07:25 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't return plain integer 0, instead return NULL
> 
> Fixes sparse warning:
> warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This does not apply cleanly to the net-next tree.

Patch hide | download patch | download mbox

diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 7b0b399aaedd..13a35f504081 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -1303,7 +1303,7 @@  static struct sk_buff *bcmgenet_free_tx_cb(struct device *dev,
 		dma_unmap_addr_set(cb, dma_addr, 0);
 	}
 
-	return 0;
+	return NULL;
 }
 
 /* Simple helper to free a receive control block's resources */