From patchwork Mon Jul 17 02:12:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emoly Liu X-Patchwork-Id: 789181 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3x9myv6Yf2z9sRV for ; Mon, 17 Jul 2017 12:12:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751289AbdGQCMj convert rfc822-to-8bit (ORCPT ); Sun, 16 Jul 2017 22:12:39 -0400 Received: from mga01.intel.com ([192.55.52.88]:58255 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbdGQCMi (ORCPT ); Sun, 16 Jul 2017 22:12:38 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2017 19:12:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,372,1496127600"; d="scan'208";a="993699450" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 16 Jul 2017 19:12:37 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 16 Jul 2017 19:12:37 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 16 Jul 2017 19:12:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.151]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Mon, 17 Jul 2017 10:12:35 +0800 From: "Liu, Emoly" To: "tytso@mit.edu" CC: "linux-ext4@vger.kernel.org" Subject: RE: [PATCH] ext4: error should be cleared if ea_inode isn't added to the cache Thread-Topic: [PATCH] ext4: error should be cleared if ea_inode isn't added to the cache Thread-Index: AQHS+sL2GUyolq414ES0DCyN6ICnUaJXTK4g Date: Mon, 17 Jul 2017 02:12:34 +0000 Message-ID: <07A0E441A926DB4D91D25518F435CC777C9D62FD@SHSMSX104.ccr.corp.intel.com> References: <1499831813-13218-1-git-send-email-emoly.liu@intel.com> In-Reply-To: <1499831813-13218-1-git-send-email-emoly.liu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmIyNzQ1MDAtZWVhZS00N2QyLWI4N2MtMjNkOWNlMmMxODhkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkQ5cHg5Rk5Ma1wvSUJMTXMyK0k3Q0sxVHJiVmJFSHhsXC9iUjBTbnY1RUxWOD0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi, This patch needs to be included into the release along with the ea_inode feature to maintain proper feature compatibility with Lustre. Could it be landed as soon as possible? Thanks, Emoly -----Original Message----- From: Emoly Liu [mailto:emoly.liu@intel.com] Sent: Wednesday, July 12, 2017 11:57 AM To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org; Liu, Emoly Subject: [PATCH] ext4: error should be cleared if ea_inode isn't added to the cache For Lustre, if ea_inode fails in hash validation but passes parent inode and generation checks, it won't be added to the cache as well as the error "-EFSCORRUPTED" should be cleared, otherwise it will cause "Structure needs cleaning" when running getfattr command. Signed-off-by: Emoly Liu Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9723 --- fs/ext4/xattr.c | 1 + 1 file changed, 1 insertion(+) -- 1.8.3.1 diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index cff4f41..de217a0 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -451,6 +451,7 @@ static int ext4_xattr_inode_iget(struct inode *parent, unsigned long ea_ino, } /* Do not add ea_inode to the cache. */ ea_inode_cache = NULL; + err = 0; } else if (err) goto out;