| Message ID | 1500238735-30283-1-git-send-email-vlee@freedesktop.org |
|---|---|
| State | Superseded |
| Headers | show |
On 2017-07-16 01:58 PM, Vinson Lee wrote: > Signed-off-by: Vinson Lee <vlee@freedesktop.org> > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index 954bb0c2..9205e463 100644 > --- a/README > +++ b/README > @@ -6,7 +6,7 @@ Quick Start Guide > > 1) Dependencies: > > - autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms, libfdt-dev > + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, libjson-c-dev, flex, bison, dkms, libfdt-dev > > 2) To build and install (only if building from source) > > Thanks for pointing this out, and I noticed it syas "libjson0-dev | libjson-c-dev (>= 0.9)" in debian/control. Should we list "libjson0-dev | libjson-c-dev" in README too? Colin, do you have any suggestions?
On 18/07/17 19:11, Alex Hung wrote: > On 2017-07-16 01:58 PM, Vinson Lee wrote: >> Signed-off-by: Vinson Lee <vlee@freedesktop.org> >> --- >> README | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/README b/README >> index 954bb0c2..9205e463 100644 >> --- a/README >> +++ b/README >> @@ -6,7 +6,7 @@ Quick Start Guide >> 1) Dependencies: >> - autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, >> libjson0-dev, flex, bison, dkms, libfdt-dev >> + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, >> libjson-c-dev, flex, bison, dkms, libfdt-dev >> 2) To build and install (only if building from source) >> > > Thanks for pointing this out, and I noticed it syas "libjson0-dev | > libjson-c-dev (>= 0.9)" in debian/control. Should we list "libjson0-dev > | libjson-c-dev" in README too? Yes please > > Colin, do you have any suggestions? >
On Tue, Jul 18, 2017 at 1:26 PM, Colin Ian King <colin.king@canonical.com> wrote: > On 18/07/17 19:11, Alex Hung wrote: >> On 2017-07-16 01:58 PM, Vinson Lee wrote: >>> Signed-off-by: Vinson Lee <vlee@freedesktop.org> >>> --- >>> README | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/README b/README >>> index 954bb0c2..9205e463 100644 >>> --- a/README >>> +++ b/README >>> @@ -6,7 +6,7 @@ Quick Start Guide >>> 1) Dependencies: >>> - autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, >>> libjson0-dev, flex, bison, dkms, libfdt-dev >>> + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, >>> libjson-c-dev, flex, bison, dkms, libfdt-dev >>> 2) To build and install (only if building from source) >>> >> >> Thanks for pointing this out, and I noticed it syas "libjson0-dev | >> libjson-c-dev (>= 0.9)" in debian/control. Should we list "libjson0-dev >> | libjson-c-dev" in README too? > > Yes please > I submitted a follow-up patch to do this. However, fwts is supported for only trusty and later and trusty already has libjson-c-dev. >> >> Colin, do you have any suggestions? >> > > > -- > fwts-devel mailing list > fwts-devel@lists.ubuntu.com > Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
diff --git a/README b/README index 954bb0c2..9205e463 100644 --- a/README +++ b/README @@ -6,7 +6,7 @@ Quick Start Guide 1) Dependencies: - autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, libjson0-dev, flex, bison, dkms, libfdt-dev + autoconf, automake, libglib2.0-dev, libtool, libpcre3-dev, libjson-c-dev, flex, bison, dkms, libfdt-dev 2) To build and install (only if building from source)
Signed-off-by: Vinson Lee <vlee@freedesktop.org> --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)