ext4: correct comment references to ext4_ext_direct_IO()

Submitted by Eric Whitney on July 14, 2017, 9:04 p.m.

Details

Message ID 20170714210426.GB12793@localhost.localdomain
State New
Headers show

Commit Message

Eric Whitney July 14, 2017, 9:04 p.m.
Commit 914f82a32d0268847 "ext4: refactor direct IO code" deleted
ext4_ext_direct_IO(), but references to that function remain in
comments.  Update them to refer to ext4_direct_IO_write().

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
 fs/ext4/inode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andreas Dilger July 14, 2017, 9:18 p.m.
On Jul 14, 2017, at 2:04 PM, Eric Whitney <enwlinux@gmail.com> wrote:
> 
> Commit 914f82a32d0268847 "ext4: refactor direct IO code" deleted
> ext4_ext_direct_IO(), but references to that function remain in
> comments.  Update them to refer to ext4_direct_IO_write().
> 
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 3c600f0..2e6c022 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -892,7 +892,7 @@ static int ext4_dio_get_block_unwritten_async(struct inode *inode,
> /*
>  * Get block function for non-AIO DIO writes when we create unwritten extent if
>  * blocks are not allocated yet. The extent will be converted to written
> - * after IO is complete from ext4_ext_direct_IO() function.
> + * after IO is complete by ext4_direct_IO_write().
>  */
> static int ext4_dio_get_block_unwritten_sync(struct inode *inode,
> 		sector_t iblock, struct buffer_head *bh_result,	int create)
> @@ -907,7 +907,7 @@ static int ext4_dio_get_block_unwritten_sync(struct inode *inode,
> 
> 	/*
> 	 * Mark inode as having pending DIO writes to unwritten extents.
> -	 * ext4_ext_direct_IO() checks this flag and converts extents to
> +	 * ext4_direct_IO_write() checks this flag and converts extents to
> 	 * written.
> 	 */
> 	if (!ret && buffer_unwritten(bh_result))
> --
> 2.1.4
> 


Cheers, Andreas
Jan Kara July 25, 2017, 10:56 a.m.
On Fri 14-07-17 17:04:26, Eric Whitney wrote:
> Commit 914f82a32d0268847 "ext4: refactor direct IO code" deleted
> ext4_ext_direct_IO(), but references to that function remain in
> comments.  Update them to refer to ext4_direct_IO_write().
> 
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/inode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 3c600f0..2e6c022 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -892,7 +892,7 @@ static int ext4_dio_get_block_unwritten_async(struct inode *inode,
>  /*
>   * Get block function for non-AIO DIO writes when we create unwritten extent if
>   * blocks are not allocated yet. The extent will be converted to written
> - * after IO is complete from ext4_ext_direct_IO() function.
> + * after IO is complete by ext4_direct_IO_write().
>   */
>  static int ext4_dio_get_block_unwritten_sync(struct inode *inode,
>  		sector_t iblock, struct buffer_head *bh_result,	int create)
> @@ -907,7 +907,7 @@ static int ext4_dio_get_block_unwritten_sync(struct inode *inode,
>  
>  	/*
>  	 * Mark inode as having pending DIO writes to unwritten extents.
> -	 * ext4_ext_direct_IO() checks this flag and converts extents to
> +	 * ext4_direct_IO_write() checks this flag and converts extents to
>  	 * written.
>  	 */
>  	if (!ret && buffer_unwritten(bh_result))
> -- 
> 2.1.4
>

Patch hide | download patch | download mbox

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 3c600f0..2e6c022 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -892,7 +892,7 @@  static int ext4_dio_get_block_unwritten_async(struct inode *inode,
 /*
  * Get block function for non-AIO DIO writes when we create unwritten extent if
  * blocks are not allocated yet. The extent will be converted to written
- * after IO is complete from ext4_ext_direct_IO() function.
+ * after IO is complete by ext4_direct_IO_write().
  */
 static int ext4_dio_get_block_unwritten_sync(struct inode *inode,
 		sector_t iblock, struct buffer_head *bh_result,	int create)
@@ -907,7 +907,7 @@  static int ext4_dio_get_block_unwritten_sync(struct inode *inode,
 
 	/*
 	 * Mark inode as having pending DIO writes to unwritten extents.
-	 * ext4_ext_direct_IO() checks this flag and converts extents to
+	 * ext4_direct_IO_write() checks this flag and converts extents to
 	 * written.
 	 */
 	if (!ret && buffer_unwritten(bh_result))