[02/15] libwebsockets: support libressl

Submitted by Adam Duskett on July 14, 2017, 6:15 p.m.

Details

Message ID 20170714181537.17479-2-aduskett@gmail.com
State New
Headers show

Commit Message

Adam Duskett July 14, 2017, 6:15 p.m.
Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
 package/libwebsockets/libwebsockets.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Petazzoni July 14, 2017, 10:08 p.m.
Hello,

On Fri, 14 Jul 2017 14:15:24 -0400, Adam Duskett wrote:

> +else ifeq ($(BR2_PACKAGE_LIBRESSL),y)
> +LIBWEBSOCKETS_DEPENDENCIES += libressl host-openssl
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=ON

I'm wondering: do we want to mix using libressl on the target, and
openssl on the host?

I don't necessarily see a big problem with this, but I'm just
wondering, since it might be a bit confusing.

Arnout, what do you think?

Best regards,

Thomas
Adam Duskett July 15, 2017, 5:32 p.m.
Hello;

On Fri, Jul 14, 2017 at 6:08 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 14 Jul 2017 14:15:24 -0400, Adam Duskett wrote:
>
>> +else ifeq ($(BR2_PACKAGE_LIBRESSL),y)
>> +LIBWEBSOCKETS_DEPENDENCIES += libressl host-openssl
>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=ON
>
> I'm wondering: do we want to mix using libressl on the target, and
> openssl on the host?
>
> I don't necessarily see a big problem with this, but I'm just
> wondering, since it might be a bit confusing.
>
I know you asked Arnout, but I wanted to throw my two cents in here
as well.

If I make libressl a host package, Libwebsockets compiles and works
just fine with it.  I would personally like to make libressl a host package as
well.

> Arnout, what do you think?
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
Arnout Vandecappelle July 18, 2017, 7:38 p.m.
On 15-07-17 19:32, Adam Duskett wrote:
> Hello;
> 
> On Fri, Jul 14, 2017 at 6:08 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Hello,
>>
>> On Fri, 14 Jul 2017 14:15:24 -0400, Adam Duskett wrote:
>>
>>> +else ifeq ($(BR2_PACKAGE_LIBRESSL),y)
>>> +LIBWEBSOCKETS_DEPENDENCIES += libressl host-openssl
>>> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=ON
>>
>> I'm wondering: do we want to mix using libressl on the target, and
>> openssl on the host?
>>
>> I don't necessarily see a big problem with this, but I'm just
>> wondering, since it might be a bit confusing.
>>
> I know you asked Arnout, but I wanted to throw my two cents in here
> as well.
> 
> If I make libressl a host package, Libwebsockets compiles and works
> just fine with it.  I would personally like to make libressl a host package as
> well.

 Sounds good to me. If libressl ever becomes a virtual package, it will go that
route anyway.

 Regards,
 Arnout

Patch hide | download patch | download mbox

diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
index b29a2f14c..b6a1db779 100644
--- a/package/libwebsockets/libwebsockets.mk
+++ b/package/libwebsockets/libwebsockets.mk
@@ -24,6 +24,9 @@  endif
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBWEBSOCKETS_DEPENDENCIES += openssl host-openssl
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=ON
+else ifeq ($(BR2_PACKAGE_LIBRESSL),y)
+LIBWEBSOCKETS_DEPENDENCIES += libressl host-openssl
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=ON
 else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif