Patchwork [25/25] Specs cleanup: -Qn/-Qy

login
register
mail settings
Submitter Joseph S. Myers
Date Jan. 14, 2011, 12:20 a.m.
Message ID <Pine.LNX.4.64.1101140020360.6059@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/78853/
State New
Headers show

Comments

Joseph S. Myers - Jan. 14, 2011, 12:20 a.m.
There are various specs passing -Qn/-Qy options to the assembler and
linker.  For the GNU tools these are no-ops where accepted (and %{Qy:}
is in any case always a no-op spec).  This patch removes those specs
except for Solaris and QNX.  OK to commit?

2011-01-13  Joseph Myers  <joseph@codesourcery.com>

	* config/bfin/bfin.h (LINK_SPEC): Remove %{Qy:} %{!Qn:-Qy}.
	* config/frv/frv.h (LINK_SPEC): Likewise.
	* config/i386/netware.h (LINK_SPEC): Likewise.
	* config/m68k/linux.h (ASM_SPEC): Likewise.
	* config/rs6000/linux64.h (ASM_SPEC_COMMON): Likewise.
	* config/rs6000/sysv4.h (LINK_SPEC): Likewise.
	* config/rs6000/vxworks.h (ASM_SPEC): Likewise.
	* config/sparc/linux.h (ASM_SPEC): Likewise.
	* config/sparc/linux64.h (ASM_SPEC): Likewise.
	* config/sparc/sp-elf.h (ASM_SPEC): Likewise.
	* config/sparc/sysv4.h (ASM_SPEC): Likewise.
Eric Botcazou - Jan. 14, 2011, 9:19 a.m.
> 2011-01-13  Joseph Myers  <joseph@codesourcery.com>
>
> 	* config/bfin/bfin.h (LINK_SPEC): Remove %{Qy:} %{!Qn:-Qy}.
> 	* config/frv/frv.h (LINK_SPEC): Likewise.
> 	* config/i386/netware.h (LINK_SPEC): Likewise.
> 	* config/m68k/linux.h (ASM_SPEC): Likewise.
> 	* config/rs6000/linux64.h (ASM_SPEC_COMMON): Likewise.
> 	* config/rs6000/sysv4.h (LINK_SPEC): Likewise.
> 	* config/rs6000/vxworks.h (ASM_SPEC): Likewise.
> 	* config/sparc/linux.h (ASM_SPEC): Likewise.
> 	* config/sparc/linux64.h (ASM_SPEC): Likewise.
> 	* config/sparc/sp-elf.h (ASM_SPEC): Likewise.
> 	* config/sparc/sysv4.h (ASM_SPEC): Likewise.

I'd leave it again for config/sparc/sysv4.h.  Otherwise OK for the SPARC bits.
Joseph S. Myers - Jan. 26, 2011, 5:54 p.m.
Ping.  The non-SPARC parts of this patch 
<http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00914.html> are pending 
review.
Richard Guenther - Jan. 26, 2011, 7:25 p.m.
On Wed, Jan 26, 2011 at 6:54 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> Ping.  The non-SPARC parts of this patch
> <http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00914.html> are pending
> review.

Ok.

Thanks,
Richard.

> --
> Joseph S. Myers
> joseph@codesourcery.com
>

Patch

diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/bfin/bfin.h gcc-mainline/gcc/config/bfin/bfin.h
--- gcc-mainline-24/gcc/config/bfin/bfin.h	2011-01-12 15:18:36.000000000 -0800
+++ gcc-mainline/gcc/config/bfin/bfin.h	2011-01-12 15:20:58.000000000 -0800
@@ -248,7 +248,6 @@  extern unsigned int bfin_workarounds;
 %{static:-dn -Bstatic} \
 %{shared:-G -Bdynamic} \
 %{symbolic:-Bsymbolic} \
-%{Qy:} %{!Qn:-Qy} \
 -init __init -fini __fini "
 
 /* Generate DSP instructions, like DSP halfword loads */
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/frv/frv.h gcc-mainline/gcc/config/frv/frv.h
--- gcc-mainline-24/gcc/config/frv/frv.h	2011-01-12 15:18:43.000000000 -0800
+++ gcc-mainline/gcc/config/frv/frv.h	2011-01-12 15:21:07.000000000 -0800
@@ -126,8 +126,7 @@ 
 %{static:-dn -Bstatic} \
 %{shared:-Bdynamic} \
 %{symbolic:-Bsymbolic} \
-%{G*} \
-%{Qy:} %{!Qn:-Qy}"
+%{G*}"
 
 #undef  LIB_SPEC
 #define LIB_SPEC "--start-group -lc -lsim --end-group"
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/i386/netware.h gcc-mainline/gcc/config/i386/netware.h
--- gcc-mainline-24/gcc/config/i386/netware.h	2011-01-12 15:16:45.000000000 -0800
+++ gcc-mainline/gcc/config/i386/netware.h	2011-01-12 15:21:14.000000000 -0800
@@ -34,8 +34,7 @@  along with GCC; see the file COPYING3.  
 
 /* Kinda useless, but what the hell */
 #undef	LINK_SPEC
-#define LINK_SPEC "%{h*} %{v:-V} \
-		   %{Qy:} %{!Qn:-Qy}"
+#define LINK_SPEC "%{h*} %{v:-V}"
 
 #undef	STARTFILE_SPEC
 #define STARTFILE_SPEC ""
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/m68k/linux.h gcc-mainline/gcc/config/m68k/linux.h
--- gcc-mainline-24/gcc/config/m68k/linux.h	2011-01-12 15:18:52.000000000 -0800
+++ gcc-mainline/gcc/config/m68k/linux.h	2011-01-12 15:21:24.000000000 -0800
@@ -24,8 +24,7 @@  along with GCC; see the file COPYING3.  
 
 /* Add %(asm_cpu_spec) to a generic definition of ASM_SPEC.  */
 #undef ASM_SPEC
-#define ASM_SPEC "%(asm_cpu_spec) %(asm_pcrel_spec) \
-  %{Qy:} %{!Qn:-Qy}"
+#define ASM_SPEC "%(asm_cpu_spec) %(asm_pcrel_spec)"
 
 #undef PREFERRED_STACK_BOUNDARY
 #define PREFERRED_STACK_BOUNDARY 32
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/rs6000/linux64.h gcc-mainline/gcc/config/rs6000/linux64.h
--- gcc-mainline-24/gcc/config/rs6000/linux64.h	2011-01-12 15:19:08.000000000 -0800
+++ gcc-mainline/gcc/config/rs6000/linux64.h	2011-01-12 15:21:39.000000000 -0800
@@ -207,7 +207,6 @@  extern int dot_symbols;
 
 #define ASM_SPEC_COMMON "%(asm_cpu) \
 %{,assembler|,assembler-with-cpp: %{mregnames} %{mno-regnames}} \
-%{Qy:} %{!Qn:-Qy} \
 %{mlittle} %{mlittle-endian} %{mbig} %{mbig-endian}"
 
 #undef	SUBSUBTARGET_EXTRA_SPECS
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/rs6000/sysv4.h gcc-mainline/gcc/config/rs6000/sysv4.h
--- gcc-mainline-24/gcc/config/rs6000/sysv4.h	2011-01-12 15:17:06.000000000 -0800
+++ gcc-mainline/gcc/config/rs6000/sysv4.h	2011-01-12 15:21:45.000000000 -0800
@@ -619,7 +619,6 @@  extern int fixuplabelno;
 #define	LINK_SPEC "\
 %{h*} %{v:-V} %{!msdata=none:%{G*}} %{msdata=none:-G0} \
 %{R*} \
-%{Qy:} %{!Qn:-Qy} \
 %(link_shlib) \
 %{!T*: %(link_start) } \
 %(link_target) \
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/rs6000/vxworks.h gcc-mainline/gcc/config/rs6000/vxworks.h
--- gcc-mainline-24/gcc/config/rs6000/vxworks.h	2011-01-12 15:19:14.000000000 -0800
+++ gcc-mainline/gcc/config/rs6000/vxworks.h	2011-01-12 15:21:51.000000000 -0800
@@ -85,7 +85,6 @@  VXWORKS_ADDITIONAL_CPP_SPEC
 #define ASM_SPEC \
 "%(asm_cpu) \
  %{,assembler|,assembler-with-cpp: %{mregnames} %{mno-regnames}} \
- %{Qy:} %{!Qn:-Qy} \
  %{mrelocatable} %{mrelocatable-lib} %{fpic:-K PIC} %{fPIC:-K PIC} -mbig"
 
 #undef  LIB_SPEC
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/sparc/linux.h gcc-mainline/gcc/config/sparc/linux.h
--- gcc-mainline-24/gcc/config/sparc/linux.h	2011-01-12 15:19:22.000000000 -0800
+++ gcc-mainline/gcc/config/sparc/linux.h	2011-01-12 15:22:00.000000000 -0800
@@ -85,7 +85,6 @@  along with GCC; see the file COPYING3.  
 /* It's safe to pass -s always, even if -g is not used.  */
 #undef ASM_SPEC
 #define ASM_SPEC "\
-%{!Qn:-Qy} \
 -s \
 %{fpic|fPIC|fpie|fPIE:-K PIC} \
 %{!.c:%{findirect-dispatch:-K PIC}} \
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/sparc/linux64.h gcc-mainline/gcc/config/sparc/linux64.h
--- gcc-mainline-24/gcc/config/sparc/linux64.h	2011-01-12 15:19:28.000000000 -0800
+++ gcc-mainline/gcc/config/sparc/linux64.h	2011-01-12 15:22:06.000000000 -0800
@@ -208,7 +208,6 @@  along with GCC; see the file COPYING3.  
 /* It's safe to pass -s always, even if -g is not used.  */
 #undef ASM_SPEC
 #define ASM_SPEC "\
-%{!Qn:-Qy} \
 -s \
 %{fpic|fPIC|fpie|fPIE:-K PIC} \
 %{!.c:%{findirect-dispatch:-K PIC}} \
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/sparc/sp-elf.h gcc-mainline/gcc/config/sparc/sp-elf.h
--- gcc-mainline-24/gcc/config/sparc/sp-elf.h	2011-01-12 15:19:35.000000000 -0800
+++ gcc-mainline/gcc/config/sparc/sp-elf.h	2011-01-12 15:22:14.000000000 -0800
@@ -27,7 +27,7 @@  along with GCC; see the file COPYING3.  
 /* It's safe to pass -s always, even if -g is not used.  */
 #undef ASM_SPEC
 #define ASM_SPEC \
-  "%{Qy:} %{!Qn:-Qy} -s \
+  "-s \
    %{fpic|fpie|fPIC|fPIE:-K PIC} %(asm_cpu)"
 
 /* Use the default.  */
diff -rupN --exclude=.svn gcc-mainline-24/gcc/config/sparc/sysv4.h gcc-mainline/gcc/config/sparc/sysv4.h
--- gcc-mainline-24/gcc/config/sparc/sysv4.h	2011-01-12 15:19:41.000000000 -0800
+++ gcc-mainline/gcc/config/sparc/sysv4.h	2011-01-12 15:22:21.000000000 -0800
@@ -46,8 +46,7 @@  along with GCC; see the file COPYING3.  
 /* Pass -K to the assembler when PIC.  */
 #undef ASM_SPEC
 #define ASM_SPEC \
-  "%{Qy:} %{!Qn:-Qy} \
-   %{fpic|fPIC|fpie|fPIE:-K PIC} %(asm_cpu)"
+  "%{fpic|fPIC|fpie|fPIE:-K PIC} %(asm_cpu)"
 
 /* Define the names of various pseudo-op used by the SPARC/svr4 assembler.
    Note that many of these are different from the typical pseudo-ops used