Patchwork [17/25] Specs cleanup: rs6000 -profile

login
register
mail settings
Submitter Joseph S. Myers
Date Jan. 14, 2011, 12:14 a.m.
Message ID <Pine.LNX.4.64.1101140013310.6059@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/78845/
State New
Headers show

Comments

Joseph S. Myers - Jan. 14, 2011, 12:14 a.m.
As noted for patch 8 in this series, the -profile option logically is
a target OS one, not a target architecture one.  rs6000/sysv4.h
defines a spec for NetBSD supporting this option; no other NetBSD
target has this option.  vxworks.h defines CC1_SPEC supporting this
option; no other VxWorks target has this option.  This patch removes
both specs.  OK to commit?

2011-01-13  Joseph Myers  <joseph@codesourcery.com>

	* config/rs6000/sysv4.h (LIB_NETBSD_SPEC): Don't handle -profile.
	* config/rs6000/vxworks.h (CC1_SPEC): Don't handle -profile.
Nathan Sidwell - Jan. 14, 2011, 7:58 a.m.
On 01/14/11 00:14, Joseph S. Myers wrote:
> As noted for patch 8 in this series, the -profile option logically is
> a target OS one, not a target architecture one.  rs6000/sysv4.h
> defines a spec for NetBSD supporting this option; no other NetBSD
> target has this option.  vxworks.h defines CC1_SPEC supporting this
> option; no other VxWorks target has this option.  This patch removes
> both specs.  OK to commit?

ok.  I am unaware of any profiling support on any vxworks target.  It's probably 
historical accident rs6000/vxworks.h has the option.

nathan
Joseph S. Myers - Jan. 26, 2011, 5:52 p.m.
Ping.  The NetBSD part of this patch 
<http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00906.html> is pending 
review (sorry, I forgot to include the NetBSD target maintainers on the 
original patch submission).
Krister Walfridsson - Jan. 27, 2011, 6:22 p.m.
On Wed, Jan 26, 2011 at 6:52 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
>
> Ping.  The NetBSD part of this patch
> <http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00906.html> is pending
> review (sorry, I forgot to include the NetBSD target maintainers on the
> original patch submission).

This is OK to commit.

   /Krister

Patch

diff -rupN --exclude=.svn gcc-mainline-16/gcc/config/rs6000/sysv4.h gcc-mainline/gcc/config/rs6000/sysv4.h
--- gcc-mainline-16/gcc/config/rs6000/sysv4.h	2011-01-12 14:40:04.000000000 -0800
+++ gcc-mainline/gcc/config/rs6000/sysv4.h	2011-01-12 14:43:03.000000000 -0800
@@ -872,7 +872,7 @@  extern int fixuplabelno;
 
 /* NetBSD support.  */
 #define LIB_NETBSD_SPEC "\
-%{profile:-lgmon -lc_p} %{!profile:-lc}"
+-lc"
 
 #define	STARTFILE_NETBSD_SPEC "\
 ncrti.o%s crt0.o%s \
diff -rupN --exclude=.svn gcc-mainline-16/gcc/config/rs6000/vxworks.h gcc-mainline/gcc/config/rs6000/vxworks.h
--- gcc-mainline-16/gcc/config/rs6000/vxworks.h	2011-01-12 14:03:03.000000000 -0800
+++ gcc-mainline/gcc/config/rs6000/vxworks.h	2011-01-12 14:43:16.000000000 -0800
@@ -81,7 +81,6 @@  VXWORKS_ADDITIONAL_CPP_SPEC
 #define CC1_SPEC						\
 "%{G*} %{mno-sdata:-msdata=none} %{msdata:-msdata=default}	\
  %{mlittle|mlittle-endian:-mstrict-align}			\
- %{profile: -p}		\
  %{fvec:-maltivec} %{fvec-eabi:-maltivec -mabi=altivec}"
 
 #define ASM_SPEC \