From patchwork Fri Jul 14 11:46:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 788383 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x89tM2wgjz9s76 for ; Fri, 14 Jul 2017 21:48:11 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iSRCRXWf"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3x89tM0w8WzDqg2 for ; Fri, 14 Jul 2017 21:48:11 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iSRCRXWf"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-lf0-x231.google.com (mail-lf0-x231.google.com [IPv6:2a00:1450:4010:c07::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3x89rj5DW0zDqg2 for ; Fri, 14 Jul 2017 21:46:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iSRCRXWf"; dkim-atps=neutral Received: by mail-lf0-x231.google.com with SMTP id z78so52426389lff.0 for ; Fri, 14 Jul 2017 04:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=LO0N3KpPlkiOar0zvtkIFCCChTfZFWTVRq9Pendcgfc=; b=iSRCRXWfC8BasHVs6CSJJSwMONYnMMIfrn2K8fRLuh+S54S7hfSFdHw0s5EJoifuTd NM4OybRG82wic43SNRHc91UlbGGK3138BoXRRLYX3HVhRqH2OdjNX+Db0hjXO+Su1PXt m52rDD1wI0+H9QPoDpTvJvX7ePtA+HGgAfKYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LO0N3KpPlkiOar0zvtkIFCCChTfZFWTVRq9Pendcgfc=; b=QNlU4ZLcwQ+S/VQct6TGrYUl7dqiOTKlSzR4OQRaBgzL5maxeOSIAD6PcmmpwnHX4P 3DB20/KE8kVnMnATB7ENW6SvCR5VQj8bHIVoe4bEOsN6dR/bpABB3IGrgHZOA+1Fz/ig +u92tJUNNGjD2phsdvXxZScuVhxcusasmNGHginsulPAqoYG1QuoOtQ74aLVYaiL4aMo bGZkQBO/POkIWPrfX90PyDoKMUbaQbQ9RfQubJJBxPudEmYT8Va0AunMMe1bDBA8KKjF lt90c9UwOUrW72ctRLCXrg5uA2+nkfpIRLGNqA240kZ19I1SN7/J6chXllHhhVRZFQQx aOmw== X-Gm-Message-State: AIVw110Y4nOLAwnE6/riEb862bhbMB2G9pC5E68I6QQR4EZPr134CpCp OftMGEADXJLzj638 X-Received: by 10.46.84.74 with SMTP id y10mr775032ljd.77.1500032799497; Fri, 14 Jul 2017 04:46:39 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id h4sm1748283ljb.50.2017.07.14.04.46.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jul 2017 04:46:38 -0700 (PDT) From: Linus Walleij To: Benjamin Herrenschmidt Subject: [PATCH] machintosh: select defaults for cooling Date: Fri, 14 Jul 2017 13:46:29 +0200 Message-Id: <20170714114629.1512-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.9.4 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linuxppc-dev@lists.ozlabs.org, opensuse-ppc@opensuse.org, stable@vger.kernel.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" I have this pretty nasty problem when trying to boot up a fresh openSuSE DVD on a PowerMac G5: the kernel by default does not have CONFIG_WINDFARM_PM72 enabled, with the effect that the cooling is not functioning. The BIOS on the PowerMac G5 reacts to this by, after a grace period when the BIOS has waited for the OS to take over, increasing the fan speeds so it sounds like an airplane is in the room, and after another grace period simply cutting the power to the machine. This is done not beacuse the cooling is not working, but because the BIOS is not recieving handover of cooling from the OS, so it panics and give up. The problem has been reported by Linux users online. Needless to say, this makes it impossible to install the OS before the machine turns itself off. The g5_defconfig looks like this: CONFIG_PMAC_SMU=y CONFIG_WINDFARM=y CONFIG_WINDFARM_PM81=y CONFIG_WINDFARM_PM91=y CONFIG_WINDFARM_PM112=y CONFIG_WINDFARM_PM121=y Notably PM72 is missing, making the PowerMac G5 fail. The defconfig is not the right place to do this: it should be done by default when selecting Mac support for PPC/PPC64 and especially for the Macs CPUfreq driver. We select SMU by default for PPC_PMAC64, WINDFARM by default on PPC_PMAC and all the WINDFARM thermal managers by default if CPU_FREQ_PMAC64 is selected. I think this will make install images work in the G5 Macs. Cc: stable@vger.kernel.org Signed-off-by: Linus Walleij --- drivers/macintosh/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig index 97a420c11eed..d7186d8f30a9 100644 --- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig @@ -101,6 +101,7 @@ config ADB_PMU_LED_DISK config PMAC_SMU bool "Support for SMU based PowerMacs" depends on PPC_PMAC64 + default PPC_PMAC64 help This option adds support for the newer G5 iMacs and PowerMacs based on the "SMU" system control chip which replaces the old PMU. @@ -194,11 +195,13 @@ config THERM_ADT746X config WINDFARM tristate "New PowerMac thermal control infrastructure" depends on PPC + default PPC_PMAC config WINDFARM_PM81 tristate "Support for thermal management on iMac G5" depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && PMAC_SMU select I2C_POWERMAC + default CPU_FREQ_PMAC64 help This driver provides thermal control for the iMacG5 @@ -206,6 +209,7 @@ config WINDFARM_PM72 tristate "Support for thermal management on PowerMac G5 (AGP)" depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && ADB_PMU select I2C_POWERMAC + default CPU_FREQ_PMAC64 help This driver provides thermal control for the PowerMac G5 "AGP" variants (PowerMac 7,2 and 7,3) @@ -214,6 +218,7 @@ config WINDFARM_RM31 tristate "Support for thermal management on Xserve G5" depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && ADB_PMU select I2C_POWERMAC + default CPU_FREQ_PMAC64 help This driver provides thermal control for the Xserve G5 (RackMac3,1) @@ -222,6 +227,7 @@ config WINDFARM_PM91 tristate "Support for thermal management on PowerMac9,1" depends on WINDFARM && I2C && CPU_FREQ_PMAC64 && PMAC_SMU select I2C_POWERMAC + default CPU_FREQ_PMAC64 help This driver provides thermal control for the PowerMac9,1 which is the recent (SMU based) single CPU desktop G5