Patchwork [07/25] Specs cleanup: -gline

login
register
mail settings
Submitter Joseph S. Myers
Date Jan. 14, 2011, 12:06 a.m.
Message ID <Pine.LNX.4.64.1101140006200.6059@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/78834/
State New
Headers show

Comments

Joseph S. Myers - Jan. 14, 2011, 12:06 a.m.
Two targets have %{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1}}}}} in
CC1_SPEC.  This is not useful or effective to create a -gline option,
since all -g* options are passed to cc1 automatically
(gcc.c:cc1_options) and so -gline will be passed and rejected by cc1
as unknown.  This patch removes those specs.  OK to commit?

2011-01-13  Joseph Myers  <joseph@codesourcery.com>

	* config/microblaze/microblaze.h (CC1_SPEC): Remove -gline spec.
	* config/mips/mips.h (CC1_SPEC): Likewise.
Michael Eager - Jan. 14, 2011, 7:27 a.m.
Joseph S. Myers wrote:
> Two targets have %{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1}}}}} in
> CC1_SPEC.  This is not useful or effective to create a -gline option,
> since all -g* options are passed to cc1 automatically
> (gcc.c:cc1_options) and so -gline will be passed and rejected by cc1
> as unknown.  This patch removes those specs.  OK to commit?

OK for MicroBlaze.

Thanks for the cleanup work!

Patch

diff -rupN --exclude=.svn gcc-mainline-6/gcc/config/microblaze/microblaze.h gcc-mainline/gcc/config/microblaze/microblaze.h
--- gcc-mainline-6/gcc/config/microblaze/microblaze.h	2011-01-12 14:11:16.000000000 -0800
+++ gcc-mainline/gcc/config/microblaze/microblaze.h	2011-01-12 14:13:00.000000000 -0800
@@ -93,7 +93,7 @@  extern enum pipeline_type microblaze_pip
 
 #ifndef CC1_SPEC
 #define CC1_SPEC " \
-%{G*} %{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1}}}}} \
+%{G*} \
 %(subtarget_cc1_spec) \
 %{mxl-multiply-high:-mcpu=v6.00.a} \
 "
diff -rupN --exclude=.svn gcc-mainline-6/gcc/config/mips/mips.h gcc-mainline/gcc/config/mips/mips.h
--- gcc-mainline-6/gcc/config/mips/mips.h	2011-01-12 14:11:25.000000000 -0800
+++ gcc-mainline/gcc/config/mips/mips.h	2011-01-12 14:13:10.000000000 -0800
@@ -1168,7 +1168,6 @@  enum mips_code_readable_setting {
 
 #undef CC1_SPEC
 #define CC1_SPEC "\
-%{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1}}}}} \
 %{G*} %{EB:-meb} %{EL:-mel} %{EB:%{EL:%emay not use both -EB and -EL}} \
 %(subtarget_cc1_spec)"