Patchwork [03/25] Specs cleanup: -version

login
register
mail settings
Submitter Joseph S. Myers
Date Jan. 14, 2011, 12:03 a.m.
Message ID <Pine.LNX.4.64.1101140002080.6059@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/78830/
State New
Headers show

Comments

Joseph S. Myers - Jan. 14, 2011, 12:03 a.m.
The option -version (single leading '-') is an option to the core
compiler (cc1 etc.) only, generated from the driver -v option and
marked RejectDriver in common.opt.  As such, it does not make sense
for specs to patch it; this patch removes two specs doing so.  OK to
commit?

2011-01-13  Joseph Myers  <joseph@codesourcery.com>

	* config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Remove
	%{version:-v}.
	* config/lm32/uclinux-elf.h (LINK_SPEC): Likewise.
Richard Earnshaw - Jan. 14, 2011, 9:47 a.m.
On Fri, 2011-01-14 at 00:03 +0000, Joseph S. Myers wrote:
> The option -version (single leading '-') is an option to the core
> compiler (cc1 etc.) only, generated from the driver -v option and
> marked RejectDriver in common.opt.  As such, it does not make sense
> for specs to patch it; this patch removes two specs doing so.  OK to
> commit?
> 
> 2011-01-13  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Remove
> 	%{version:-v}.
> 	* config/lm32/uclinux-elf.h (LINK_SPEC): Likewise.
> 

OK.

R.

Patch

diff -rupN --exclude=.svn gcc-mainline-2/gcc/config/arm/linux-elf.h gcc-mainline/gcc/config/arm/linux-elf.h
--- gcc-mainline-2/gcc/config/arm/linux-elf.h	2011-01-12 13:52:52.000000000 -0800
+++ gcc-mainline/gcc/config/arm/linux-elf.h	2011-01-12 13:59:36.000000000 -0800
@@ -64,7 +64,7 @@ 
 
 #define GLIBC_DYNAMIC_LINKER "/lib/ld-linux.so.2"
 
-#define LINUX_TARGET_LINK_SPEC  "%{h*} %{version:-v} \
+#define LINUX_TARGET_LINK_SPEC  "%{h*} \
    %{static:-Bstatic} \
    %{shared:-shared} \
    %{symbolic:-Bsymbolic} \
diff -rupN --exclude=.svn gcc-mainline-2/gcc/config/lm32/uclinux-elf.h gcc-mainline/gcc/config/lm32/uclinux-elf.h
--- gcc-mainline-2/gcc/config/lm32/uclinux-elf.h	2010-12-09 05:38:53.000000000 -0800
+++ gcc-mainline/gcc/config/lm32/uclinux-elf.h	2011-01-12 13:59:50.000000000 -0800
@@ -67,7 +67,7 @@ 
   "%{!shared:crtend.o%s} %{shared:crtendS.o%s} crtn.o%s"
 
 #undef  LINK_SPEC
-#define LINK_SPEC "%{h*} %{version:-v} \
+#define LINK_SPEC "%{h*} \
    %{static:-Bstatic} \
    %{shared:-shared} \
    %{symbolic:-Bsymbolic} \