Message ID | Pine.LNX.4.64.1101140000570.6059@digraph.polyomino.org.uk |
---|---|
State | New |
Headers | show |
> In <http://gcc.gnu.org/ml/gcc-patches/2010-12/msg00195.html> I removed > various %{v} and %{v:-V} assembler specs that would only be used with > the GNU assembler. This patch removes some more such specs; none of > these end up being used on Solaris, the only SPARC target that may use > a non-GNU assembler. OK to commit? > > 2011-01-13 Joseph Myers <joseph@codesourcery.com> > > * config/sparc/sp-elf.h (ASM_SPEC): Remove %{v:-V}. > * config/sparc/sp64-elf.h (ASM_SPEC): Likewise. > * config/sparc/sysv4.h (ASM_SPEC): Likewise. I'd leave it in config/sparc/sysv4.h for the mythical SPARC/svr4 assembler. OK for 4.6 with this change.
On Fri, 14 Jan 2011, Eric Botcazou wrote: > > In <http://gcc.gnu.org/ml/gcc-patches/2010-12/msg00195.html> I removed > > various %{v} and %{v:-V} assembler specs that would only be used with > > the GNU assembler. This patch removes some more such specs; none of > > these end up being used on Solaris, the only SPARC target that may use > > a non-GNU assembler. OK to commit? > > > > 2011-01-13 Joseph Myers <joseph@codesourcery.com> > > > > * config/sparc/sp-elf.h (ASM_SPEC): Remove %{v:-V}. > > * config/sparc/sp64-elf.h (ASM_SPEC): Likewise. > > * config/sparc/sysv4.h (ASM_SPEC): Likewise. > > I'd leave it in config/sparc/sysv4.h for the mythical SPARC/svr4 assembler. > > OK for 4.6 with this change. I'll apply with that change for now, and likewise for the other patches but if any targets turn out to be using ASM_SPEC from sparc/sysv4.h that shouldn't get the -Ym, the result will be adding new versions of ASM_SPEC to other headers (meaning nothing at all ends up using ASM_SPEC from sparc/sysv4.h) to avoid adding inappropriate options to .opt files. (I generally think config/<arch>/sysv4.h headers suffer the same problems (of there being no generic SVR4 targets for which they are appropriate) that resulted in my eliminating the config/svr4.h file, although to a lesser extent.)
diff -rupN --exclude=.svn gcc-mainline-1/gcc/config/sparc/sp-elf.h gcc-mainline/gcc/config/sparc/sp-elf.h --- gcc-mainline-1/gcc/config/sparc/sp-elf.h 2010-12-09 05:38:50.000000000 -0800 +++ gcc-mainline/gcc/config/sparc/sp-elf.h 2011-01-12 13:56:56.000000000 -0800 @@ -28,7 +28,7 @@ along with GCC; see the file COPYING3. It's safe to pass -s always, even if -g is not used. */ #undef ASM_SPEC #define ASM_SPEC \ - "%{v:-V} %{Qy:} %{!Qn:-Qy} %{Ym,*} -s \ + "%{Qy:} %{!Qn:-Qy} %{Ym,*} -s \ %{fpic|fpie|fPIC|fPIE:-K PIC} %(asm_cpu)" /* Use the default. */ diff -rupN --exclude=.svn gcc-mainline-1/gcc/config/sparc/sp64-elf.h gcc-mainline/gcc/config/sparc/sp64-elf.h --- gcc-mainline-1/gcc/config/sparc/sp64-elf.h 2010-12-06 06:43:00.000000000 -0800 +++ gcc-mainline/gcc/config/sparc/sp64-elf.h 2011-01-12 13:57:19.000000000 -0800 @@ -40,7 +40,7 @@ along with GCC; see the file COPYING3. #undef ASM_SPEC #define ASM_SPEC "\ -%{v:-V} -s %{fpic|fPIC|fpie|fPIE:-K PIC} \ +-s %{fpic|fPIC|fpie|fPIE:-K PIC} \ %{mlittle-endian:-EL} \ %(asm_cpu) %(asm_arch) \ " diff -rupN --exclude=.svn gcc-mainline-1/gcc/config/sparc/sysv4.h gcc-mainline/gcc/config/sparc/sysv4.h --- gcc-mainline-1/gcc/config/sparc/sysv4.h 2010-12-20 13:15:09.000000000 -0800 +++ gcc-mainline/gcc/config/sparc/sysv4.h 2011-01-12 13:57:32.000000000 -0800 @@ -46,7 +46,7 @@ along with GCC; see the file COPYING3. /* Pass -K to the assembler when PIC. */ #undef ASM_SPEC #define ASM_SPEC \ - "%{v:-V} %{Qy:} %{!Qn:-Qy} %{Ym,*} %{Yd,*} \ + "%{Qy:} %{!Qn:-Qy} %{Ym,*} %{Yd,*} \ %{fpic|fPIC|fpie|fPIE:-K PIC} %(asm_cpu)" /* Define the names of various pseudo-op used by the SPARC/svr4 assembler.