Patchwork [Build,libquadmath] PR 47182 Fix BUGURL in libquadmath.texi

login
register
mail settings
Submitter Tobias Burnus
Date Jan. 13, 2011, 9:49 p.m.
Message ID <4D2F735E.8050205@net-b.de>
Download mbox | patch
Permalink /patch/78815/
State New
Headers show

Comments

Tobias Burnus - Jan. 13, 2011, 9:49 p.m.
The patch fixes setting the bugurl in libquadmath. The code mimics the 
one in in gcc/{configure.ac,Makefile.in,doc/include/gcc-common.texi} 
(the latter includes the generated gcc-vers.texi).

Build and regtested on x86-64-linux.
OK for the trunk?

Tobias
Ralf Wildenhues - Jan. 14, 2011, 6:16 a.m.
* Tobias Burnus wrote on Thu, Jan 13, 2011 at 10:49:18PM CET:
> The patch fixes setting the bugurl in libquadmath. The code mimics
> the one in in
> gcc/{configure.ac,Makefile.in,doc/include/gcc-common.texi} (the
> latter includes the generated gcc-vers.texi).
> 
> Build and regtested on x86-64-linux.
> OK for the trunk?

FWIW the patch looks OK to me.

Thanks,
Ralf

> 2011-01-14  Tobias Burnus  <burnus@net-b.de>
> 
> 	PR fortran/47182
> 	* configure.ac: Use ACX_BUGURL.
> 	* libquadmath.texi: Include libquadmath-vers.texi for BUGURL.
> 	* Makefile.am: Create libquadmath-vers.texi.
> 	* configure.in: Regenerate.
> 	* Makefile.in: Regenerate.
Tobias Burnus - Jan. 14, 2011, 7:20 a.m.
Ralf Wildenhues wrote:
> * Tobias Burnus wrote on Thu, Jan 13, 2011 at 10:49:18PM CET:
>> Build and regtested on x86-64-linux.
>> OK for the trunk?
> FWIW the patch looks OK to me.

Well, as the interesting part is the build part - I declared the .texi 
part as obvious and have committed it as Rev. 168776.

Thanks for the (partial) review!

Tobias

>> 2011-01-14  Tobias Burnus<burnus@net-b.de>
>>
>> 	PR fortran/47182
>> 	* configure.ac: Use ACX_BUGURL.
>> 	* libquadmath.texi: Include libquadmath-vers.texi for BUGURL.
>> 	* Makefile.am: Create libquadmath-vers.texi.
>> 	* configure.in: Regenerate.
>> 	* Makefile.in: Regenerate.

Patch

2011-01-14  Tobias Burnus  <burnus@net-b.de>

	PR fortran/47182
	* configure.ac: Use ACX_BUGURL.
	* libquadmath.texi: Include libquadmath-vers.texi for BUGURL.
	* Makefile.am: Create libquadmath-vers.texi.
	* configure.in: Regenerate.
	* Makefile.in: Regenerate.

Index: libquadmath/configure.ac
===================================================================
--- libquadmath/configure.ac	(Revision 168765)
+++ libquadmath/configure.ac	(Arbeitskopie)
@@ -49,6 +49,7 @@  ACX_CHECK_PROG_VER([MAKEINFO], [makeinfo], [--vers
                    [4.[4-9]*|4.[1-9][0-9]*|[5-9]*|[1-9][0-9]*])
 AM_CONDITIONAL(BUILD_INFO, test $gcc_cv_prog_makeinfo_modern = "yes")
 
+ACX_BUGURL([http://gcc.gnu.org/bugs.html])
 
 # Configure libtool
 AM_PROG_LIBTOOL
Index: libquadmath/libquadmath.texi
===================================================================
--- libquadmath/libquadmath.texi	(Revision 168765)
+++ libquadmath/libquadmath.texi	(Arbeitskopie)
@@ -272,6 +272,9 @@  int main ()
 @c Reporting Bugs
 @c ---------------------------------------------------------------------
 
+@c For BUGURL
+@include libquadmath-vers.texi
+
 @node Reporting Bugs
 @chapter Reporting Bugs
 
Index: libquadmath/Makefile.am
===================================================================
--- libquadmath/Makefile.am	(Revision 168765)
+++ libquadmath/Makefile.am	(Arbeitskopie)
@@ -126,7 +126,7 @@  stamp-geninsrc: libquadmath.info
 	cp -p $(top_builddir)/libquadmath.info $(srcdir)/libquadmath.info
 	@touch $@
 
-stamp-build-info: libquadmath.texi
+stamp-build-info: libquadmath.texi $(libquadmath_TEXINFOS)
 	$(MAKEINFO) $(AM_MAKEINFOFLAGS) $(MAKEINFOFLAGS) -I $(srcdir) -o libquadmath.info $(srcdir)/libquadmath.texi
 	@touch $@
 
@@ -150,3 +150,7 @@  TEXINFO_TEX   = ../gcc/doc/include/texinfo.tex
 # Defines info, dvi, pdf and html targets
 MAKEINFOFLAGS = -I $(srcdir)/../gcc/doc/include
 info_TEXINFOS = libquadmath.texi
+libquadmath_TEXINFOS = libquadmath-vers.texi
+
+libquadmath-vers.texi:
+	echo "@set BUGURL $(REPORT_BUGS_TEXI)" > $@