From patchwork Thu Jan 13 20:25:20 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 78808 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6D9BBB6EED for ; Fri, 14 Jan 2011 07:25:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933805Ab1AMUZX (ORCPT ); Thu, 13 Jan 2011 15:25:23 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:25787 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933786Ab1AMUZV (ORCPT ); Thu, 13 Jan 2011 15:25:21 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 879119403D; Thu, 13 Jan 2011 21:25:20 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 859A09403B; Thu, 13 Jan 2011 21:25:20 +0100 (CET) Date: Thu, 13 Jan 2011 21:25:20 +0100 (CET) From: Jesper Juhl To: netdev@vger.kernel.org cc: linux-kernel@vger.kernel.org, Ramkrishna Vepa , Jon Mason , Sivakumar Subramani , Sreenivasa Honnur Subject: [PATCH] vxge: Remember to release firmware after upgrading firmware Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Regardless of whether the firmware update being performed by vxge_fw_upgrade() is a success or not we must still remember to always release_firmware() before returning. Signed-off-by: Jesper Juhl Acked-by: Ram Vepa --- vxge-main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c index 1ac9b56..c81a651 100644 --- a/drivers/net/vxge/vxge-main.c +++ b/drivers/net/vxge/vxge-main.c @@ -4120,6 +4120,7 @@ int vxge_fw_upgrade(struct vxgedev *vdev, char *fw_name, int override) "hotplug event.\n"); out: + release_firmware(fw); return ret; }