Patchwork [testsuite,fortran] Increase gfortran.dg/cray_pointers_2.f90 timeout

login
register
mail settings
Submitter Rainer Orth
Date Jan. 13, 2011, 5:36 p.m.
Message ID <ydd7he87lks.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/78786/
State New
Headers show

Comments

Rainer Orth - Jan. 13, 2011, 5:36 p.m.
I regularly see the gfortran.dg/cray_pointers_2.f90 timeout on slower
platforms.  I've run the -O3 test on various idle systems and found the
following user times:

1.2 GHz UltraSPARC-T2	1:15.65
250 MHz MIPS R10000	2:58.72
200 MHz MIPS R4400      7:57.07

Obviously, the times increase under load (i.e. make -jN check with N >
ncpus), therefore I'd like to increase the timeout factor by for to
account even for the loaded R4k case.

The total runtime of this single testcase on my R4k box is 47 min,
btw. ;-(  This seems quite excessive.

Unless the patch can be simplified somewhat to reduce the compilation
time, I'd like to install the following patch on trunk, 4.4 and 4.5
branches.

Tested by the appropriate runtest invocation on mips-sgi-irix5.3.

Ok everywhere?

Thanks.
	Rainer


2011-01-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* gfortran.dg/cray_pointers_2.f90: Use dg-timeout-factor 4.
Tobias Burnus - Jan. 13, 2011, 5:44 p.m.
On 01/13/2011 06:36 PM, Rainer Orth wrote:
> The total runtime of this single testcase on my R4k box is 47 min,
> btw. ;-(  This seems quite excessive.
:-(

> Unless the patch can be simplified somewhat to reduce the compilation
> time, I'd like to install the following patch on trunk, 4.4 and 4.5
> branches.

I think reducing the test itself is not really an option. What would 
help is to run it only once - and not several times with different 
options. That's a test case which should work with all options if it 
works with -O3. However, I have no idea how to convince DejaGNU to 
compile/run this particular test case only once.

> Tested by the appropriate runtest invocation on mips-sgi-irix5.3.
> Ok everywhere?
OK.

Tobias
Rainer Orth - Jan. 13, 2011, 7:05 p.m.
Tobias Burnus <burnus@net-b.de> writes:

>> Unless the patch can be simplified somewhat to reduce the compilation
>> time, I'd like to install the following patch on trunk, 4.4 and 4.5
>> branches.
>
> I think reducing the test itself is not really an option. What would help
> is to run it only once - and not several times with different
> options. That's a test case which should work with all options if it works
> with -O3. However, I have no idea how to convince DejaGNU to compile/run
> this particular test case only once.

I'll have a look if I can figure out how to do this.

>> Tested by the appropriate runtest invocation on mips-sgi-irix5.3.
>> Ok everywhere?
> OK.

Thanks, installed.

	Rainer

Patch

diff -r df72bcbc4f49 gcc/testsuite/gfortran.dg/cray_pointers_2.f90
--- a/gcc/testsuite/gfortran.dg/cray_pointers_2.f90	Thu Jan 13 11:16:57 2011 +0100
+++ b/gcc/testsuite/gfortran.dg/cray_pointers_2.f90	Thu Jan 13 17:26:32 2011 +0100
@@ -1,5 +1,6 @@ 
 ! { dg-do run }
 ! { dg-options "-fcray-pointer -fbounds-check -fno-inline" }
+! { dg-timeout-factor 4 }
 !
 ! Series of routines for testing a Cray pointer implementation
 !