Message ID | 1499955874-10954-1-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1499955874-10954-1-git-send-email-pbonzini@redhat.com Subject: [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/1499955697-28045-1-git-send-email-peter.maydell@linaro.org -> patchew/1499955697-28045-1-git-send-email-peter.maydell@linaro.org * [new tag] patchew/1499955874-10954-1-git-send-email-pbonzini@redhat.com -> patchew/1499955874-10954-1-git-send-email-pbonzini@redhat.com * [new tag] patchew/1499958932-23839-1-git-send-email-peter.maydell@linaro.org -> patchew/1499958932-23839-1-git-send-email-peter.maydell@linaro.org - [tag update] patchew/20170713110237.6712-1-lprosek@redhat.com -> patchew/20170713110237.6712-1-lprosek@redhat.com * [new tag] patchew/20170713144352.2212-1-berrange@redhat.com -> patchew/20170713144352.2212-1-berrange@redhat.com * [new tag] patchew/20170713153028.31065-1-el13635@mail.ntua.gr -> patchew/20170713153028.31065-1-el13635@mail.ntua.gr Switched to a new branch 'test' 6d67cf3 translate-all: remove redundant !tcg_enabled check in dump_exec_info 46b92a9 vl: fix breakage of -tb-size 4c7de34 nbd: Implement NBD_INFO_BLOCK_SIZE on client 280da19 nbd: Implement NBD_INFO_BLOCK_SIZE on server 8abe2ce nbd: Implement NBD_OPT_GO on client 0a397be nbd: Implement NBD_OPT_GO on server 2bbad3f nbd: Refactor reply to NBD_OPT_EXPORT_NAME 474ef00 nbd: Simplify trace of client flags in negotiation 080f569 nbd: Expose and debug more NBD constants c5ea916 nbd: Don't bother tracing an NBD_OPT_ABORT response failure 8921348 nbd: Create struct for tracking export info c36ec9b memory/iommu: introduce IOMMUMemoryRegionClass 9897b91 memory/iommu: QOM'fy IOMMU MemoryRegion eb1a75c chardev: fix parallel device can't be reconnect a862860 gdbstub: don't fail on vCont; C04:0; c packets d47bd46 qom/cpu: remove host_tid field 4220a85 gdbstub: rename cpu_index -> cpu_gdb_index 2810341 gdbstub: modernise DEBUG_GDB 3b7ce63 mttcg/i386: Patch instruction using async_safe_* framework bdbca69 Revert "exec.c: Fix breakpoint invalidation race" d060d0e exec: use qemu_ram_ptr_length to access guest ram c76c3bb serial: chardev hotswap support 79796d4 serial: move TIOCM update to a separate function be08fcf virtio-console: chardev hotswap support e522bda hmp: add hmp analogue for qmp-chardev-change 64ce47e test-char: add hotswap test e54fca6 test-char: split char_file_test d971065 test-char: split char_udp_test b823a3b test-char: destroy chardev-udp after test e7ba7f5 char: avoid chardevice direct access 4638b74 char: forbid direct chardevice access for hotswap devices f560498 char: chardevice hotswap 919f86c char: add backend hotswap handler d00a58a char: move QemuOpts->ChardevBackend translation to a separate func 97d7b48 chardev: block during sync read e5b1de4 MAINTAINERS: add entry for "Unimplemented" device d55179c MAINTAINERS: update TCI entry e6b5227 MAINTAINERS: update Xen entries b35e727 MAINTAINERS: update KVM entries 4b2ee70 MAINTAINERS: update TCG entries cd26684 build: add -Wexpansion-to-defined === OUTPUT BEGIN === Checking PATCH 1/41: build: add -Wexpansion-to-defined... Checking PATCH 2/41: MAINTAINERS: update TCG entries... Checking PATCH 3/41: MAINTAINERS: update KVM entries... Checking PATCH 4/41: MAINTAINERS: update Xen entries... Checking PATCH 5/41: MAINTAINERS: update TCI entry... Checking PATCH 6/41: MAINTAINERS: add entry for "Unimplemented" device... Checking PATCH 7/41: chardev: block during sync read... Checking PATCH 8/41: char: move QemuOpts->ChardevBackend translation to a separate func... Checking PATCH 9/41: char: add backend hotswap handler... WARNING: line over 80 characters #725: FILE: target/xtensa/xtensa-semi.c:161: + qemu_chr_fe_set_handlers(&console, NULL, NULL, NULL, NULL, NULL, NULL, true); total: 0 errors, 1 warnings, 544 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 10/41: char: chardevice hotswap... Checking PATCH 11/41: char: forbid direct chardevice access for hotswap devices... Checking PATCH 12/41: char: avoid chardevice direct access... Checking PATCH 13/41: test-char: destroy chardev-udp after test... Checking PATCH 14/41: test-char: split char_udp_test... Checking PATCH 15/41: test-char: split char_file_test... Checking PATCH 16/41: test-char: add hotswap test... Checking PATCH 17/41: hmp: add hmp analogue for qmp-chardev-change... Checking PATCH 18/41: virtio-console: chardev hotswap support... Checking PATCH 19/41: serial: move TIOCM update to a separate function... Checking PATCH 20/41: serial: chardev hotswap support... Checking PATCH 21/41: exec: use qemu_ram_ptr_length to access guest ram... Checking PATCH 22/41: Revert "exec.c: Fix breakpoint invalidation race"... Checking PATCH 23/41: mttcg/i386: Patch instruction using async_safe_* framework... Checking PATCH 24/41: gdbstub: modernise DEBUG_GDB... Checking PATCH 25/41: gdbstub: rename cpu_index -> cpu_gdb_index... Checking PATCH 26/41: qom/cpu: remove host_tid field... Checking PATCH 27/41: gdbstub: don't fail on vCont; C04:0; c packets... Checking PATCH 28/41: chardev: fix parallel device can't be reconnect... Checking PATCH 29/41: memory/iommu: QOM'fy IOMMU MemoryRegion... ERROR: spaces required around that '*' (ctx:WxO) #133: FILE: hw/dma/rc4030.c:720: +DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr) ^ total: 1 errors, 0 warnings, 772 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 30/41: memory/iommu: introduce IOMMUMemoryRegionClass... Checking PATCH 31/41: nbd: Create struct for tracking export info... Checking PATCH 32/41: nbd: Don't bother tracing an NBD_OPT_ABORT response failure... Checking PATCH 33/41: nbd: Expose and debug more NBD constants... Checking PATCH 34/41: nbd: Simplify trace of client flags in negotiation... Checking PATCH 35/41: nbd: Refactor reply to NBD_OPT_EXPORT_NAME... Checking PATCH 36/41: nbd: Implement NBD_OPT_GO on server... Checking PATCH 37/41: nbd: Implement NBD_OPT_GO on client... Checking PATCH 38/41: nbd: Implement NBD_INFO_BLOCK_SIZE on server... Checking PATCH 39/41: nbd: Implement NBD_INFO_BLOCK_SIZE on client... Checking PATCH 40/41: vl: fix breakage of -tb-size... Checking PATCH 41/41: translate-all: remove redundant !tcg_enabled check in dump_exec_info... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On 13/07/2017 18:05, no-reply@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > False positive due to non-camelcase type in hw/dma/rc4030.c. > Checking PATCH 29/41: memory/iommu: QOM'fy IOMMU MemoryRegion... > ERROR: spaces required around that '*' (ctx:WxO) > #133: FILE: hw/dma/rc4030.c:720: > +DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr) Thanks, Paolo