Patchwork [U-Boot,v3,4/4] SMDK6400: Fix SMDK6400 SDRAM init

login
register
mail settings
Submitter seedshope
Date Jan. 13, 2011, 1:36 p.m.
Message ID <1294925784-5042-5-git-send-email-bocui107@gmail.com>
Download mbox | patch
Permalink /patch/78756/
State Rejected
Headers show

Comments

seedshope - Jan. 13, 2011, 1:36 p.m.
Since SDRAM init function have already change, So the SDRAM
initial function must be change.

Signed-off-by: seedshope <bocui107@gmail.com>
Minkyu Kang - Jan. 14, 2011, 12:53 a.m.
Dear seedshope,

On 13 January 2011 22:36, seedshope <bocui107@gmail.com> wrote:
> Since SDRAM init function have already change, So the SDRAM
> initial function must be change.
>
> Signed-off-by: seedshope <bocui107@gmail.com>
>
> diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c
> index 35aa40b..043d553 100644
> --- a/board/samsung/smdk6400/smdk6400.c
> +++ b/board/samsung/smdk6400/smdk6400.c
> @@ -78,10 +78,18 @@ int board_init(void)
>        return 0;
>  }
>
> -int dram_init(void)
> +void dram_init_banksize(void)
>  {
> +       DECLARE_GLOBAL_DATA_PTR;

Please move it to out of function.

> +
>        gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>        gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> +}
> +
> +int dram_init(void)
> +{
> +       gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE, \

Please remove "\".

> +                       PHYS_SDRAM_1_SIZE);
>
>        return 0;
>  }
> --
> 1.7.1
>
>

Thanks
Minkyu Kang
seedshope - Jan. 14, 2011, 3:51 p.m.
On 01/14/2011 08:53 AM, Minkyu Kang wrote:
> Dear seedshope,
>
> On 13 January 2011 22:36, seedshope<bocui107@gmail.com>  wrote:
>> Since SDRAM init function have already change, So the SDRAM
>> initial function must be change.
>>
>> Signed-off-by: seedshope<bocui107@gmail.com>
>>
>> diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c
>> index 35aa40b..043d553 100644
>> --- a/board/samsung/smdk6400/smdk6400.c
>> +++ b/board/samsung/smdk6400/smdk6400.c
>> @@ -78,10 +78,18 @@ int board_init(void)
>>         return 0;
>>   }
>>
>> -int dram_init(void)
>> +void dram_init_banksize(void)
>>   {
>> +       DECLARE_GLOBAL_DATA_PTR;
> Please move it to out of function.
I am sorry, DECLARE_GLOBAL_DATA_PTR have already defind  in the head of 
the file,
I will drop this declare.
>> +
>>         gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>>         gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +}
>> +
>> +int dram_init(void)
>> +{
>> +       gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE, \
> Please remove "\".
>
ok

Thanks,
seedshope
>> +                       PHYS_SDRAM_1_SIZE);
>>
>>         return 0;
>>   }
>> --
>> 1.7.1
>>
>>
> Thanks
> Minkyu Kang

Patch

diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c
index 35aa40b..043d553 100644
--- a/board/samsung/smdk6400/smdk6400.c
+++ b/board/samsung/smdk6400/smdk6400.c
@@ -78,10 +78,18 @@  int board_init(void)
 	return 0;
 }
 
-int dram_init(void)
+void dram_init_banksize(void)
 {
+	DECLARE_GLOBAL_DATA_PTR;
+
 	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
 	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+}
+
+int dram_init(void)
+{
+	gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE, \
+			PHYS_SDRAM_1_SIZE);
 
 	return 0;
 }