From patchwork Thu Jan 13 12:14:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun Bharadwaj X-Patchwork-Id: 78735 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B7E46B6F14 for ; Thu, 13 Jan 2011 23:24:54 +1100 (EST) Received: from localhost ([127.0.0.1]:43328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PdMEV-00040G-QO for incoming@patchwork.ozlabs.org; Thu, 13 Jan 2011 07:24:51 -0500 Received: from [140.186.70.92] (port=41608 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PdM4x-0007ue-T1 for qemu-devel@nongnu.org; Thu, 13 Jan 2011 07:15:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PdM4w-0001qM-NY for qemu-devel@nongnu.org; Thu, 13 Jan 2011 07:14:59 -0500 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:52716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PdM4w-0001pe-1d for qemu-devel@nongnu.org; Thu, 13 Jan 2011 07:14:58 -0500 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp03.in.ibm.com (8.14.4/8.13.1) with ESMTP id p0DCEsV7008306 for ; Thu, 13 Jan 2011 17:44:54 +0530 Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0DCErln2637856 for ; Thu, 13 Jan 2011 17:44:53 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0DCErYV013689 for ; Thu, 13 Jan 2011 23:14:53 +1100 Received: from localhost6.localdomain6 ([9.124.35.18]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p0DCErbW013686; Thu, 13 Jan 2011 23:14:53 +1100 To: qemu-devel@nongnu.org From: Arun R Bharadwaj Date: Thu, 13 Jan 2011 17:44:53 +0530 Message-ID: <20110113121453.4487.46123.stgit@localhost6.localdomain6> In-Reply-To: <20110113120837.4487.95784.stgit@localhost6.localdomain6> References: <20110113120837.4487.95784.stgit@localhost6.localdomain6> User-Agent: StGit/0.15 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: kwolf@redhat.com, aliguori@linux.vnet.ibm.com, jvrao@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 07/12] Remove thread_create routine. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Remove thread_create and use qemu_thread_create instead. Signed-off-by: Arun R Bharadwaj --- posix-aio-compat.c | 29 ++--------------------------- 1 files changed, 2 insertions(+), 27 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index 2d73846..8c5bb46 100644 --- a/posix-aio-compat.c +++ b/posix-aio-compat.c @@ -13,7 +13,6 @@ #include #include -#include #include #include #include @@ -83,7 +82,6 @@ typedef struct PosixAioState { /* Default ThreadletQueue */ static ThreadletQueue globalqueue; static int globalqueue_init; -static pthread_attr_t attr; #ifdef CONFIG_PREADV static int preadv_present = 1; @@ -102,13 +100,6 @@ static void die(const char *what) die2(errno, what); } -static void thread_create(pthread_t *thread, pthread_attr_t *attr, - void *(*start_routine)(void*), void *arg) -{ - int ret = pthread_create(thread, attr, start_routine, arg); - if (ret) die2(ret, "pthread_create"); -} - static ssize_t handle_aiocb_ioctl(struct qemu_paiocb *aiocb) { int ret; @@ -376,19 +367,12 @@ static void handle_work(ThreadletWork *work) static void spawn_threadlet(ThreadletQueue *queue) { - pthread_t thread_id; - sigset_t set, oldset; + QemuThread thread; queue->cur_threads++; queue->idle_threads++; - /* block all signals */ - if (sigfillset(&set)) die("sigfillset"); - if (sigprocmask(SIG_SETMASK, &set, &oldset)) die("sigprocmask"); - - thread_create(&thread_id, &attr, threadlet_worker, queue); - - if (sigprocmask(SIG_SETMASK, &oldset, NULL)) die("sigprocmask restore"); + qemu_thread_create(&thread, threadlet_worker, queue); } /** @@ -661,7 +645,6 @@ int paio_init(void) struct sigaction act; PosixAioState *s; int fds[2]; - int ret; if (posix_aio_state) return 0; @@ -691,14 +674,6 @@ int paio_init(void) qemu_aio_set_fd_handler(s->rfd, posix_aio_read, NULL, posix_aio_flush, posix_aio_process_queue, s); - ret = pthread_attr_init(&attr); - if (ret) - die2(ret, "pthread_attr_init"); - - ret = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); - if (ret) - die2(ret, "pthread_attr_setdetachstate"); - posix_aio_state = s; return 0; }