diff mbox

[3/3] rtc: sun6i: Remove unneeded initalization of ret in sun6i_rtc_setalarm()

Message ID 1499857190-30849-3-git-send-email-alexey.klimov@arm.com
State Rejected
Headers show

Commit Message

Alexey Klimov July 12, 2017, 10:59 a.m. UTC
Signed-off-by: Alexey Klimov <alexey.klimov@arm.com>
---
 drivers/rtc/rtc-sun6i.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chen-Yu Tsai July 24, 2017, 3:23 a.m. UTC | #1
On Wed, Jul 12, 2017 at 6:59 PM, Alexey Klimov <alexey.klimov@arm.com> wrote:

A bit more description would be nice.

> Signed-off-by: Alexey Klimov <alexey.klimov@arm.com>

Otherwise,

Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Alexandre Belloni July 30, 2017, 2:41 p.m. UTC | #2
Hi,

On 12/07/2017 at 11:59:50 +0100, Alexey Klimov wrote:
> Signed-off-by: Alexey Klimov <alexey.klimov@arm.com>
> ---
>  drivers/rtc/rtc-sun6i.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 77bc4d3..1886b85 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -362,7 +362,7 @@ static int sun6i_rtc_setalarm(struct device *dev, struct rtc_wkalrm *wkalrm)
>  	unsigned long time_now = 0;
>  	unsigned long time_set = 0;
>  	unsigned long time_gap = 0;
> -	int ret = 0;
> +	int ret;
>  

I don't see any reason that would justify that change.

>  	ret = sun6i_rtc_gettime(dev, &tm_now);
>  	if (ret < 0) {
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
index 77bc4d3..1886b85 100644
--- a/drivers/rtc/rtc-sun6i.c
+++ b/drivers/rtc/rtc-sun6i.c
@@ -362,7 +362,7 @@  static int sun6i_rtc_setalarm(struct device *dev, struct rtc_wkalrm *wkalrm)
 	unsigned long time_now = 0;
 	unsigned long time_set = 0;
 	unsigned long time_gap = 0;
-	int ret = 0;
+	int ret;
 
 	ret = sun6i_rtc_gettime(dev, &tm_now);
 	if (ret < 0) {