| Message ID | 1294907135-24884-4-git-send-email-daniel@gaisler.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Daniel Hellstrom <daniel@gaisler.com> Date: Thu, 13 Jan 2011 09:25:29 +0100 > The greth_compat_mode option can be used to set a GRETH GBit capable MAC > in operate as if the GRETH 10/100 device was found. The GRETH GBit supports > TCP/UDP checksum offloading, unaligned frame buffers, scatter gather etc. > Enabling this mode allows the developer to test the GRETH 10/100 device > without all features mentioned above on a GBit MAC capable of the above. > > Signed-off-by: Daniel Hellstrom <daniel@gaisler.com> No special device specific module parameters please. What if every single driver author added something like this and they all named it something different or made it behave in slightly differing ways? What kind of user experience would that result in? It would result in a sucky one, which is why we avoid adding all kinds of hacky driver specific module options. Find a generic way to provide this functionality. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller wrote: >From: Daniel Hellstrom <daniel@gaisler.com> >Date: Thu, 13 Jan 2011 09:25:29 +0100 > > > >>The greth_compat_mode option can be used to set a GRETH GBit capable MAC >>in operate as if the GRETH 10/100 device was found. The GRETH GBit supports >>TCP/UDP checksum offloading, unaligned frame buffers, scatter gather etc. >>Enabling this mode allows the developer to test the GRETH 10/100 device >>without all features mentioned above on a GBit MAC capable of the above. >> >>Signed-off-by: Daniel Hellstrom <daniel@gaisler.com> >> >> > >No special device specific module parameters please. > >What if every single driver author added something like this and they >all named it something different or made it behave in slightly differing >ways? > >What kind of user experience would that result in? > >It would result in a sucky one, which is why we avoid adding all kinds >of hacky driver specific module options. > >Find a generic way to provide this functionality. > > I understand, it was not ment to be a user-experience, rather a developer debugging option. I will probably need an option like this in the future to avoid searching a very long time for very old hardware, I will try to find an other solution for it in the future. I will remove the 3 GRETH patches and resubmit the others. Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/greth.c b/drivers/net/greth.c index ef8da22..775dc24 100644 --- a/drivers/net/greth.c +++ b/drivers/net/greth.c @@ -70,6 +70,12 @@ static int no_gbit = 0; module_param(no_gbit, int, S_IRUGO); MODULE_PARM_DESC(no_gbit, "GRETH reports only 10/100 support to PHY layer if set to 1. Only affects GRETH GBit MAC, default 0 (off)."); +/* Use this option to enable GRETH 10/100 code on GRETH_GBIT hardware + * (debug legacy code option) */ +static int compat_mode = 0; +module_param(compat_mode, int, S_IRUGO); +MODULE_PARM_DESC(compat_mode, "GRETH 10/100 legacy mode enable. Only affects GRETH GBit MAC, default 0 (off)."); + static int greth_open(struct net_device *dev); static netdev_tx_t greth_start_xmit(struct sk_buff *skb, struct net_device *dev); @@ -1458,6 +1464,10 @@ static int __devinit greth_of_probe(struct platform_device *ofdev, const struct else greth->gbit_phy_support = 0; + /* Force GBit MAC in legacy 10/100 mode (no offloading etc.) */ + if (compat_mode == 1) + greth->gbit_mac = 0; + /* Check for multicast capability */ greth->multicast = (tmp >> 25) & 1;
The greth_compat_mode option can be used to set a GRETH GBit capable MAC in operate as if the GRETH 10/100 device was found. The GRETH GBit supports TCP/UDP checksum offloading, unaligned frame buffers, scatter gather etc. Enabling this mode allows the developer to test the GRETH 10/100 device without all features mentioned above on a GBit MAC capable of the above. Signed-off-by: Daniel Hellstrom <daniel@gaisler.com> --- drivers/net/greth.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)