| Message ID | 20170711181519.GA20001@embeddedgus |
|---|---|
| State | New |
| Headers | show |
SGkgR3VzdGF2bw0KDQpPbiAwNy8xMS8yMDE3IDA4OjE1IFBNLCBHdXN0YXZvIEEuIFIuIFNpbHZh IHdyb3RlOg0KPiBUaGlzIHN0cnVjdHVyZSBpcyBvbmx5IHVzZWQgdG8gY29weSBpbnRvIG90aGVy IHN0cnVjdHVyZSwgc28gZGVjbGFyZQ0KPiBpdCBhcyBjb25zdC4NCj4gDQo+IFRoaXMgaXNzdWUg d2FzIGRldGVjdGVkIHVzaW5nIENvY2NpbmVsbGUgYW5kIHRoZSBmb2xsb3dpbmcgc2VtYW50aWMg cGF0Y2g6DQo+IA0KPiBAciBkaXNhYmxlIG9wdGlvbmFsX3F1YWxpZmllckANCj4gaWRlbnRpZmll ciBpOw0KPiBwb3NpdGlvbiBwOw0KPiBAQA0KPiBzdGF0aWMgc3RydWN0IGdwaW9fY2hpcCBpQHAg PSB7IC4uLiB9Ow0KPiANCj4gQG9rQA0KPiBpZGVudGlmaWVyIHIuaTsNCj4gZXhwcmVzc2lvbiBl Ow0KPiBwb3NpdGlvbiBwOw0KPiBAQA0KPiBlID0gaUBwOw0KPiANCj4gQGJhZEANCj4gcG9zaXRp b24gcCAhPSB7ci5wLG9rLnB9Ow0KPiBpZGVudGlmaWVyIHIuaTsNCj4gc3RydWN0IGdwaW9fY2hp cCBlOw0KPiBAQA0KPiBlQGlAcA0KPiANCj4gQGRlcGVuZHMgb24gIWJhZCBkaXNhYmxlIG9wdGlv bmFsX3F1YWxpZmllckANCj4gaWRlbnRpZmllciByLmk7DQo+IEBADQo+IHN0YXRpYw0KPiArY29u c3QNCj4gICBzdHJ1Y3QgZ3Bpb19jaGlwIGkgPSB7IC4uLiB9Ow0KPiANCj4gSW4gdGhlIGZvbGxv d2luZyBsb2cgeW91IGNhbiBzZWUgYSBzaWduaWZpY2FudCBkaWZmZXJlbmNlIGluIHRoZSBjb2Rl IHNpemUNCj4gYW5kIGRhdGEgc2VnbWVudCwgaGVuY2UgaW4gdGhlIGRlYyBzZWdtZW50LiBUaGlz IGxvZyBpcyB0aGUgb3V0cHV0DQo+IG9mIHRoZSBzaXplIGNvbW1hbmQsIGJlZm9yZSBhbmQgYWZ0 ZXIgdGhlIGNvZGUgY2hhbmdlOg0KPiANCj4gYmVmb3JlOg0KPiAgICAgdGV4dCAgICBkYXRhICAg ICBic3MgICAgIGRlYyAgICAgaGV4IGZpbGVuYW1lDQo+ICAgIDIxNjcxICAgIDM2MzIgICAgIDEy OCAgIDI1NDMxICAgIDYzNTcgZHJpdmVycy9waW5jdHJsL3BpbmN0cmwtc3Qubw0KPiANCj4gYWZ0 ZXI6DQo+ICAgICB0ZXh0ICAgIGRhdGEgICAgIGJzcyAgICAgZGVjICAgICBoZXggZmlsZW5hbWUN Cj4gICAgMjEzNjYgICAgMzU3NiAgICAgMTI4ICAgMjUwNzAgICAgNjFlZSBkcml2ZXJzL3BpbmN0 cmwvcGluY3RybC1zdC5vDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZh IDxnYXJzaWx2YUBlbWJlZGRlZG9yLmNvbT4NCj4gLS0tDQo+ICAgZHJpdmVycy9waW5jdHJsL3Bp bmN0cmwtc3QuYyB8IDIgKy0NCj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BpbmN0cmwvcGluY3RybC1z dC5jIGIvZHJpdmVycy9waW5jdHJsL3BpbmN0cmwtc3QuYw0KPiBpbmRleCAzYWU4MDY2Li41ZDQ3 ODlkIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL3BpbmN0cmwvcGluY3RybC1zdC5jDQo+ICsrKyBi L2RyaXZlcnMvcGluY3RybC9waW5jdHJsLXN0LmMNCj4gQEAgLTE0NDIsNyArMTQ0Miw3IEBAIHN0 YXRpYyB2b2lkIHN0X2dwaW9faXJxbXV4X2hhbmRsZXIoc3RydWN0IGlycV9kZXNjICpkZXNjKQ0K PiAgIAljaGFpbmVkX2lycV9leGl0KGNoaXAsIGRlc2MpOw0KPiAgIH0NCj4gICANCj4gLXN0YXRp YyBzdHJ1Y3QgZ3Bpb19jaGlwIHN0X2dwaW9fdGVtcGxhdGUgPSB7DQo+ICtzdGF0aWMgY29uc3Qg c3RydWN0IGdwaW9fY2hpcCBzdF9ncGlvX3RlbXBsYXRlID0gew0KPiAgIAkucmVxdWVzdAkJPSBn cGlvY2hpcF9nZW5lcmljX3JlcXVlc3QsDQo+ICAgCS5mcmVlCQkJPSBncGlvY2hpcF9nZW5lcmlj X2ZyZWUsDQo+ICAgCS5nZXQJCQk9IHN0X2dwaW9fZ2V0LA0KPiANCg0KQWNrZWQtYnk6IFBhdHJp Y2UgQ2hvdGFyZCA8cGF0cmljZS5jaG90YXJkQHN0LmNvbT4NCg0KVGhhbmtz -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Patrice, Quoting Patrice CHOTARD <patrice.chotard@st.com>: > Hi Gustavo > > On 07/11/2017 08:15 PM, Gustavo A. R. Silva wrote: >> This structure is only used to copy into other structure, so declare >> it as const. >> >> This issue was detected using Coccinelle and the following semantic patch: >> >> @r disable optional_qualifier@ >> identifier i; >> position p; >> @@ >> static struct gpio_chip i@p = { ... }; >> >> @ok@ >> identifier r.i; >> expression e; >> position p; >> @@ >> e = i@p; >> >> @bad@ >> position p != {r.p,ok.p}; >> identifier r.i; >> struct gpio_chip e; >> @@ >> e@i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r.i; >> @@ >> static >> +const >> struct gpio_chip i = { ... }; >> >> In the following log you can see a significant difference in the code size >> and data segment, hence in the dec segment. This log is the output >> of the size command, before and after the code change: >> >> before: >> text data bss dec hex filename >> 21671 3632 128 25431 6357 drivers/pinctrl/pinctrl-st.o >> >> after: >> text data bss dec hex filename >> 21366 3576 128 25070 61ee drivers/pinctrl/pinctrl-st.o >> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> --- >> drivers/pinctrl/pinctrl-st.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c >> index 3ae8066..5d4789d 100644 >> --- a/drivers/pinctrl/pinctrl-st.c >> +++ b/drivers/pinctrl/pinctrl-st.c >> @@ -1442,7 +1442,7 @@ static void st_gpio_irqmux_handler(struct >> irq_desc *desc) >> chained_irq_exit(chip, desc); >> } >> >> -static struct gpio_chip st_gpio_template = { >> +static const struct gpio_chip st_gpio_template = { >> .request = gpiochip_generic_request, >> .free = gpiochip_generic_free, >> .get = st_gpio_get, >> > > Acked-by: Patrice Chotard <patrice.chotard@st.com> > > Thanks Glad to help. :) Thanks -- Gustavo A. R. Silva -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 11, 2017 at 8:15 PM, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote: > This structure is only used to copy into other structure, so declare > it as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct gpio_chip i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct gpio_chip e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct gpio_chip i = { ... }; > > In the following log you can see a significant difference in the code size > and data segment, hence in the dec segment. This log is the output > of the size command, before and after the code change: > > before: > text data bss dec hex filename > 21671 3632 128 25431 6357 drivers/pinctrl/pinctrl-st.o > > after: > text data bss dec hex filename > 21366 3576 128 25070 61ee drivers/pinctrl/pinctrl-st.o > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Patch applied with Patrice's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 3ae8066..5d4789d 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -1442,7 +1442,7 @@ static void st_gpio_irqmux_handler(struct irq_desc *desc) chained_irq_exit(chip, desc); } -static struct gpio_chip st_gpio_template = { +static const struct gpio_chip st_gpio_template = { .request = gpiochip_generic_request, .free = gpiochip_generic_free, .get = st_gpio_get,
This structure is only used to copy into other structure, so declare it as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; In the following log you can see a significant difference in the code size and data segment, hence in the dec segment. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 21671 3632 128 25431 6357 drivers/pinctrl/pinctrl-st.o after: text data bss dec hex filename 21366 3576 128 25070 61ee drivers/pinctrl/pinctrl-st.o Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)